Replaced SPI pin definitions for K64F in SD tests #1042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old pin definitions were all for Port D pins, which are incorrect. These improper pin mappings caused all tests to fail. Pin definitions were replaced with the definitions as stated here - http://developer.mbed.org/media/uploads/sam_grove/xk64f_sensors.jpg.pagespeed.ic.RCpM8talCK.webp Tests now pass on the K64F Sch Rev D1
|
Hello, can you sign http://developer.mbed.org/contributor_agreement/ ? I could not locate you on developer.mbed.org |
|
Looks like this pinout has changed, we were using older revision where Dports were for SD card |
|
Signed, and mentioned that signing is required in Contributing.md |
|
@bsilvereagle thanks for adding it there |
0xc0170
added a commit
that referenced
this pull request
Apr 23, 2015
Replaced SPI pin definitions for K64F in SD tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old pin definitions were all for Port D pins, which are incorrect. These improper pin mappings caused all tests to fail.
Pin definitions were replaced with the definitions as stated here -
http://developer.mbed.org/media/uploads/sam_grove/xk64f_sensors.jpg.pagespeed.ic.RCpM8talCK.webp
Tests now pass on the K64F Sch Rev D1