Skip to content

pass on asm flags for uVision project #10424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

pass on asm flags for uVision project #10424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/export/uvision/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ def format_flags(self):
'--cpreproc --cpreproc_opts=-D__ASSERT_MSG,' +
",".join("-D{}".format(s) for s in
self.toolchain.get_symbols(for_asm=True)))
flags['asm_flags'] = asm_flag_string
flags['asm_flags'] = "{} {}".format(" ".join(self.toolchain.flags['asm']), asm_flag_string)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwalton-arm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this change is in the uVision project generator it shouldn't affect the behaviour in the online build service. Meaning we shouldn't have to create another "tools-release" for the online compiler. However, as we've had this PR open since April 2019, let's wait a few more days for @Patater to return before we decide if we're going to accept it. We will need to evaluate if this actually does affect Mbed Studio or the online build service.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Patater can you please make a decision on this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: This is mandatory for the on going STM32WL target which is a M4 without FPU.
Without this patch I couldn't compile with Keil IDE. Even if export is no more mandatory for ARM, it still very appreciated from customers.
Thx

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Mbed Online IDE actually can export things, so it would affect the Online IDE.

Sorry, we can't risk breaking the online tooling right now. That's why the tools are frozen. Exporter support is important and we should work to support it from the CMake-based build system instead of merging this risky PR.


config_header = self.config_header_ref
config_option = self.toolchain.get_config_option(config_header.name)
Expand Down