-
Notifications
You must be signed in to change notification settings - Fork 3k
Size should be calculate after confirm the final start address #10448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@fredlee12001, thank you for your changes. |
@bridadan please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a correct fix. Before this comes in, would you mind posting a before and after log of the region output? I'm specifically interested in the following part, which is found at the top of the log when running mbed compile
from a project that uses a bootloader:
$ mbed compile
[mbed] Working path "C:\Users\bridan01\onedrive_arm\Documents\dev\mbed-cloud-client-example" (program)
Building project mbed-cloud-client-example (K64F, ARMC6)
Scan: mbed-cloud-client-example
Using ROM regions bootloader, header, application in this build.
Region bootloader: size 0x8000, offset 0x0
Region header: size 0x70, offset 0xa000
Region application: size 0xf5c00, offset 0xa400
Hi @bridadan , Result before the changes:
Result after the changes:
Test config value been used:
|
@fredlee12001 Please add a reasonable description in the corresponding section. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, nice work @fredlee12001 !
ci started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
The final size maybe wrong if we caculate the size before start address.
Since the start address may shift after align operation, then the final size/post address should shift as well.
Pull request type
Reviewers
Release Notes