Skip to content

Configure UNO_91H to support PDMC compile #10449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 2, 2019
Merged

Configure UNO_91H to support PDMC compile #10449

merged 4 commits into from
May 2, 2019

Conversation

fredlee12001
Copy link
Contributor

@fredlee12001 fredlee12001 commented Apr 22, 2019 •
edited
Loading

Description

1, Change target.json by add FLASHIAP, mbed address offsets etc. So that PDMC compile could pass on UNO_91H platform.
2, Add mbed APP address offset support for all 3 linker scripts.
3, UNO_91H have multi kind of flash size, add support for that by configure mbed_rom_size.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@fredlee12001
Add configuration to support PDMC compile
784f2a0 
Configurable flash size for UNO_91H
@ciarmcom
Copy link
Member

@fredlee12001, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team April 22, 2019 07:00
bulislaw
bulislaw approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @MarceloSalazar any thoughts?

@MarceloSalazar MarceloSalazar self-requested a review April 24, 2019 13:56
MarceloSalazar
MarceloSalazar approved these changes Apr 24, 2019
View reviewed changes
Copy link

@MarceloSalazar MarceloSalazar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredlee12001 thanks for the changes! These are very much needed to enable the bootloader and platform for Pelion support.
Approved, assuming all tests pass.

@adbridge
Copy link
Contributor

@fredlee12001 Please add a suitable description in the PR header.

@fredlee12001
Copy link
Contributor Author

PR description updated.

@adbridge
Copy link
Contributor

@fredlee12001 Many thanks :)

@adbridge
Copy link
Contributor

ci started

@mbed-ci
Copy link

mbed-ci commented Apr 29, 2019

Test run: FAILED

Summary: 2 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 29, 2019

Please review build failures

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 30, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Apr 30, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@adbridge
Copy link
Contributor

adbridge commented May 1, 2019

A number of random iar exporter failures, possibly a licence issue so restarted

@0xc0170
Copy link
Contributor

0xc0170 commented May 2, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented May 2, 2019

Test run: FAILED

Summary: 5 of 7 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR

@alekla01
Copy link
Contributor

alekla01 commented May 2, 2019

restarted jenkins-ci

@0xc0170
Copy link
Contributor

0xc0170 commented May 2, 2019

Ci restarted again

@mbed-ci
Copy link

mbed-ci commented May 2, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 5
Build artifacts

@0xc0170 0xc0170 merged commit bb3fdac into ARMmbed:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@MarceloSalazar MarceloSalazar MarceloSalazar approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@fredlee12001 @ciarmcom @adbridge @mbed-ci @0xc0170 @alekla01 @bulislaw @MarceloSalazar