Skip to content

LWIP 2.1.2 tcpip thread stack overflow fix. #10456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2019

Conversation

tymoteuszblochmobica
Copy link
Contributor

@tymoteuszblochmobica tymoteuszblochmobica commented Apr 23, 2019

Description

Applied missing LWIP patch to PPP/utils.c
"Major Refactoring & extensions" commited on May 23, 201 by hasnainvirk
According to this patch PPP logger module member "ppp_logit" consumes only 256 byte buffer on stack instead of 1024 like original LWIP code from Savanah repo does.

LWIP 2.1.2 tcpip thread stack is restored to 1200 bytes.

Pull request type

[x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@mikaleppanen
@kjbracey-arm
@AriParkkila
@kimlep01

Release Notes

Copy link

@AriParkkila AriParkkila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that 1600 would be enough e.g. for mbed test -c -m MTB_MTS_DRAGONFLY -n tests-network-interface --app-config=tools/test_configs/CellularInterface.json -vv, but I'm guessing that's still not the worst case..?

@tymoteuszblochmobica
Copy link
Contributor Author

Im still checking new PPP implementation to verify why more stack is needed. So now 1400 seems ok.

@ciarmcom
Copy link
Member

@tymoteuszblochmobica, thank you for your changes.
@mikaleppanen @kjbracey-arm @kimlep01 @AriParkkila @SeppoTakalo @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@AriParkkila
Copy link

@tymoteuszblochmobica I don't think 1400 is enough, could you check my comment above.

@0xc0170
Copy link
Contributor

0xc0170 commented May 3, 2019

@tymoteuszblochmobica I don't think 1400 is enough, could you check my comment above.

@tymoteuszblochmobica Please review

Applied missing LWIP patch to PPP/utils.c
"Major Refactoring & extensions" commited on May 23, 201 by hasnainvirk
LWIP 2.1.2 tcpip thread stack is restored to 1200 bytes
@tymoteuszblochmobica tymoteuszblochmobica changed the title Increase stack size for LWIP 2.1.2 tcpip thread LWIP 2.1.2 tcpip thread stack overflow fix. May 7, 2019
@tymoteuszblochmobica
Copy link
Contributor Author

Applied missing LWIP patch to PPP/utils.c
"Major Refactoring & extensions" commited on May 23, 201 by hasnainvirk
According to this patch PPP logger module member "ppp_logit" consumes only 256 byte buffer on stack instead of 1024 like original LWIP code from Savanah repo does.

LWIP 2.1.2 tcpip thread stack is restored to 1200 bytes.

@0xc0170
Copy link
Contributor

0xc0170 commented May 10, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented May 10, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 1aa95c0 into ARMmbed:master May 13, 2019
@adbridge
Copy link
Contributor

This is a 5.13 feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants