-
Notifications
You must be signed in to change notification settings - Fork 3k
LWIP 2.1.2 tcpip thread stack overflow fix. #10456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that 1600 would be enough e.g. for mbed test -c -m MTB_MTS_DRAGONFLY -n tests-network-interface --app-config=tools/test_configs/CellularInterface.json -vv
, but I'm guessing that's still not the worst case..?
Im still checking new PPP implementation to verify why more stack is needed. So now 1400 seems ok. |
@tymoteuszblochmobica, thank you for your changes. |
@tymoteuszblochmobica I don't think 1400 is enough, could you check my comment above. |
@tymoteuszblochmobica Please review |
f48b82d
to
93cca62
Compare
Applied missing LWIP patch to PPP/utils.c "Major Refactoring & extensions" commited on May 23, 201 by hasnainvirk LWIP 2.1.2 tcpip thread stack is restored to 1200 bytes
93cca62
to
461efaa
Compare
Applied missing LWIP patch to PPP/utils.c LWIP 2.1.2 tcpip thread stack is restored to 1200 bytes. |
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
This is a 5.13 feature |
Description
Applied missing LWIP patch to PPP/utils.c
"Major Refactoring & extensions" commited on May 23, 201 by hasnainvirk
According to this patch PPP logger module member "ppp_logit" consumes only 256 byte buffer on stack instead of 1024 like original LWIP code from Savanah repo does.
LWIP 2.1.2 tcpip thread stack is restored to 1200 bytes.
Pull request type
Reviewers
@SeppoTakalo
@mikaleppanen
@kjbracey-arm
@AriParkkila
@kimlep01
Release Notes