Skip to content

Cellular: Add WISE-1570 handling for socket closing URC #10463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2019
Merged

Cellular: Add WISE-1570 handling for socket closing URC #10463

merged 1 commit into from
May 3, 2019
+31 −0

Conversation

mirelachirica
Copy link
Contributor

Description

WISE-1570 wasn't handling URC for socket closing at all. Now socket closed flag is set on the arriving of such URC. Also, if the socket was closed but closed flag not yet set at the moment a socket sending/receiving was issued, the socket would get stuck waiting for data. To prevent this, socket event is called also when socket close URC arrives.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@mirelachirica mirelachirica force-pushed the wise_1570_tcp_endpoint_close branch from fd22b7c to af49acb Compare April 24, 2019 11:26
@ciarmcom ciarmcom requested a review from a team April 25, 2019 11:07
@ciarmcom
Copy link
Member

@mirelachirica, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team April 25, 2019 11:07
AriParkkila
AriParkkila suggested changes Apr 25, 2019
View reviewed changes
@mirelachirica mirelachirica force-pushed the wise_1570_tcp_endpoint_close branch from af49acb to 948f8b5 Compare April 26, 2019 07:14
@adbridge
Copy link
Contributor

@AriParkkila Could you please re-review changes?

@0xc0170 0xc0170 changed the title Cellular: Added WISE-1570 handling for socket closing URC Cellular: Add WISE-1570 handling for socket closing URC May 2, 2019
0xc0170
0xc0170 approved these changes May 2, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is simple change so its fine.

WISE-1570 wasn't handling URC for socket closing at all. Now socket closed flag is set on the arriving of such URC. Also, if the socket was closed but closed flag not yet set at the moment a socket sending/receiving was issued, the socket would get stuck waiting for data. To prevent this, socket event is called also when socket close URC arrives.

This would be nice to have in the commit msg itself.

@0xc0170
Copy link
Contributor

0xc0170 commented May 2, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented May 2, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test

@0xc0170
Copy link
Contributor

0xc0170 commented May 3, 2019

Client was restart, all OK now

@0xc0170 0xc0170 merged commit 4da21c0 into ARMmbed:master May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AriParkkila AriParkkila AriParkkila approved these changes

Assignees
No one assigned
Labels
release-version: 5.12.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mirelachirica @ciarmcom @adbridge @0xc0170 @mbed-ci @AriParkkila