Cellular: fix calls to ATHandler::read_string(...) give correct size #10465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriParkkila
approved these changes
Apr 25, 2019
| @@ -396,7 +396,7 @@ bool AT_CellularContext::get_context() | |||
| char pdp_type_from_context[10]; | |||
| int pdp_type_len = _at.read_string(pdp_type_from_context, sizeof(pdp_type_from_context) - 1); | |||
| if (pdp_type_len > 0) { | |||
| apn_len = _at.read_string(apn, sizeof(apn) - 1); | |||
| apn_len = _at.read_string(apn, sizeof(apn)); | |||
There was a problem hiding this comment.
Fix sizeof(pdp_type_from_context) two lines above as well?
| if (len > 0) { | ||
| imsi[len] = '\0'; | ||
| } | ||
| _at.read_string(imsi, MAX_IMSI_LENGTH + 1); |
There was a problem hiding this comment.
Fix _at.read_string(buf, buf_size - 1); at AT_CellularInformation::get_info too?
ATHandler::read_string(...) buffer size param was changed a long time ago to include also NULL. Some calls still gave wrong size after this change.
AriParkkila
approved these changes
Apr 25, 2019
|
@jarvte, thank you for your changes. |
AriParkkila
approved these changes
Apr 26, 2019
mirelachirica
approved these changes
Apr 26, 2019
0xc0170
approved these changes
May 2, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ATHandler::read_string(...) buffer size param was changed a long time ago to include also NULL. Some calls still gave wrong size after this change.
Pull request type
Reviewers
@AriParkkila @mirelachirica
Release Notes