Improve importer.py #10505
Merged
Improve importer.py #10505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenc17
force-pushed
the
imporve_importer
branch
from
2659a4f to
e15068d
Compare
alzix
approved these changes
Apr 28, 2019
tools/importer/importer.py
Outdated
| @@ -148,10 +153,14 @@ def get_last_cherry_pick_sha(branch): | |||
| lines = output.split('\n') | |||
| for line in lines: | |||
| if 'cherry picked from' in line: | |||
| sha = line.split(' ')[-1] | |||
| return sha[:-1] | |||
| sha = line.split(' ')[-1][:-1] | |||
There was a problem hiding this comment.
Suggested change
| sha = line.split(' ')[-1][:-1] | |
| # take the last line - git cherry-pick can add this line more | |
| # than once if used multiple times | |
| sha = line.split(' ')[-1][:-1] |
tools/importer/importer.py
Outdated
| # Set logging level | ||
| logging.basicConfig(level=level) | ||
| rel_log = logging.getLogger("Importer") | ||
|
|
||
| if (args.repo_path is None) or (args.config_file is None): | ||
| rel_log.error("Repository path and config file required as input. Use \"--help\" for more info.") | ||
| exit(1) | ||
| rel_log.error( |
There was a problem hiding this comment.
this can be replaced by required=True in parser
tools/importer/importer.py
Outdated
|
|
||
| repo = abspath(args.repo_path) | ||
| if not os.path.exists(repo): | ||
| rel_log.error("%s not found.", args.repo_path) | ||
| exit(1) | ||
| sys.exit(1) |
There was a problem hiding this comment.
use parser.error or add an action to validate it in the parser
tools/importer/importer.py
Outdated
|
|
||
| json_file = abspath(args.config_file) | ||
| if not os.path.isfile(json_file): | ||
| rel_log.error("%s not found.", args.config_file) | ||
| exit(1) | ||
| sys.exit(1) |
There was a problem hiding this comment.
use parser.error or add an action to validate it in the parser
alzix
reviewed
Apr 28, 2019
orenc17
force-pushed
the
imporve_importer
branch
from
744212c to
d1fa7bd
Compare
0xc0170
approved these changes
May 2, 2019
|
CI started |
Test run: FAILEDSummary: 2 of 11 test jobs failed Failed test jobs:
|
|
CI was restarted, all green now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve python logic and fix an issue when multiple cherry-pick messages has been added
Pull request type
Reviewers
@ARMmbed/mbed-os-tools @alzix
Release Notes