Cellular: Initialize CellularContext member variables in correct class #10557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CellularContext member variables were initialized in inheriting class. Now in base class where they should be initialized so that every inheriting class don't have to init them.
|
@jarvte, thank you for your changes. |
AriParkkila
reviewed
May 10, 2019
| @@ -19,6 +19,15 @@ | |||
|
|
|||
| namespace mbed { | |||
|
|
|||
| CellularContext::CellularContext() : _next(0), _stack(0), _pdp_type(DEFAULT_PDP_TYPE), | |||
There was a problem hiding this comment.
Should be inited in the same order as declared in header?
There was a problem hiding this comment.
Yes, and they are what I can tell. Please tell which are not in correct order.
AriParkkila
approved these changes
May 10, 2019
AnttiKauppila
approved these changes
May 13, 2019
0xc0170
approved these changes
May 13, 2019
|
CI started |
Test run: FAILEDSummary: 1 of 7 test jobs failed Failed test jobs:
|
|
CI restarted |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
adbridge
added
Manually Patch
release-version: 5.12.4
release-version: 5.13.0-rc1
and removed
release-version: 5.12.4
Manually Patch
labels
|
There is something strange, conflict wise, with both this and the related 10554 and neither will patch across to 5.12. Thus bumping to 5.13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CellularContext member variables were initialized in inheriting class.
Now in base class where they should be initialized so that every inheriting
class don't have to init them.
Pull request type
Reviewers
@AnttiKauppila
Release Notes