Disable LPTICKER on L073RZ #10572
Disable LPTICKER on L073RZ #10572
Conversation
|
@LDong-Arm, thank you for your changes. |
| @@ -22,7 +22,7 @@ | |||
| #ifndef MBED_SYS_TIMER_H | |||
| #define MBED_SYS_TIMER_H | |||
|
|
|||
| #if DEVICE_LPTICKER || defined(DOXYGEN_ONLY) | |||
| #if MBED_TICKLESS || defined(DOXYGEN_ONLY) | |||
There was a problem hiding this comment.
This impacts all the targets!
This should be checked very carefully, and should be out of this "L073RZ" PR...
There was a problem hiding this comment.
+1, PR introduction talks about fixing one target but there are fixes included impacting larger set of targets. Can we split these (l073 will be quick one to get in)
There was a problem hiding this comment.
Currently SysTimer cannot be built when lp ticker is disabled, leading to build errors of L073RZ. I'll move this SysTimer change to a separate pull request, and make the L073RZ change depend on it.
SysTimer depends on tickless which runs on us ticker instead of lp ticker on some targets.
If a ticker is unavailable its macro is undefined.
Currently LPTIM is disabled on L073RZ by
4bead92 Use the RTC for the low power ticker on L073RZ
to work around a hardware bug. But the latency of RTC is too
high (a few hundred microseconds), leading to lp_timeout
drift test failure.
For now, disable low power ticker on L073RZ altogether until
LPTIM is fixed and re-enabled.
| @@ -3352,6 +3352,7 @@ | |||
| "FLASH", | |||
| "MPU" | |||
| ], | |||
| "device_has_remove": ["LPTICKER"], | |||
There was a problem hiding this comment.
Keep this update out of the PR.
Thx
LDong-Arm
changed the title
Thanks, I've amended the title and description. Now this PR is limited to only disabling lpticker and is blocked on #10597. Could we change the label to "needs: preceding PR"? |
Description
(Depends on #10597)
LPTIM is currently disabled on L073RZ due to a hardware bug (see #10537). As an alternative, RTC is used for lp ticker. This brings a new problem that RTC-based lp ticker appears to have a high latency (of a few hundred microseconds. See #9962 for more details.
After discussing with @c1728p9, we disable lp ticker feature on L073RZ for now. This also implies tests in TESTS/mbed_drivers/lp_* will not apply to this target until we re-enable LPTIM-based lp ticker once it's fixed.
Pull request type