BLE: put the acl buffer size in config #10580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cy-kishore please comment if that works for you. |
|
@paul-szczepanek-arm, thank you for your changes. |
|
This is fine. Please merge this to mainline. |
0xc0170
approved these changes
May 15, 2019
pan-
approved these changes
May 15, 2019
| "value": 23 | ||
| }, | ||
| "rx-acl-buffer-size": { | ||
| "help": "Size of the buffer holding the ACL packet. This will limit the effective ATT_MTU (to its value minus 4 bytes for the header). The size of the buffer must be small enough to be allocated from the existing cordio pool. If this value is increased you may need to adjust the memory pool.", |
There was a problem hiding this comment.
It might be worthwhile to explain that it is the size of whole acl packet; not just the buffer used to send fragments.
There was a problem hiding this comment.
Thanks, I have made the wording more explicit.
|
Hi, regards |
|
CI started |
|
@cy-kishore will try to get this in asap |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is completely non-functional change - this simply puts the acl buffer size in a config file. Comprehensive fix that integrates with the memory pool will be scheduled later.
Pull request type
Reviewers
Release Notes