Skip to content

Introduce Semaphore::acquire methods #10596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2019
Merged

Introduce Semaphore::acquire methods #10596

merged 1 commit into from
May 29, 2019

Conversation

kjbracey
Copy link
Contributor

Deprecate wait() in favour of acquire(), try_acquire(), try_acquire_for() and try_acquire_until().

Brings Semaphore more into line with CMSIS-RTOS 2 (which uses "acquire"), itself (as it has "release"), and other classes having "try", "try for" and "try until".

Also steps away from vague "wait" term - the primary operation here is to acquire the semaphore, and this will of course sleep.

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@bulislaw

@kjbracey
Copy link
Contributor Author

This PR follows on from #10104, and I mentioned it in discussion there - I regard it as part of the same naming tidy-up. Only the one commit is new in this PR, the rest are just #10104.

@ciarmcom ciarmcom requested review from bulislaw and a team May 16, 2019 13:00
@ciarmcom
Copy link
Member

@kjbracey-arm, thank you for your changes.
@bulislaw @ARMmbed/mbed-os-core @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-test please review.

@kjbracey kjbracey force-pushed the sem_acquire branch 6 times, most recently from 7922d07 to 53995bd Compare May 22, 2019 11:13
@0xc0170
Copy link
Contributor

0xc0170 commented May 23, 2019

CI started (to get first check done)

@mbed-ci
Copy link

mbed-ci commented May 23, 2019

Test run: FAILED

Summary: 1 of 1 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests

@kjbracey kjbracey force-pushed the sem_acquire branch 2 times, most recently from 8528cb2 to 11804b3 Compare May 23, 2019 15:16
@kjbracey kjbracey force-pushed the sem_acquire branch 2 times, most recently from 7a2dc19 to cd6e345 Compare May 24, 2019 13:00
@0xc0170
Copy link
Contributor

0xc0170 commented May 24, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented May 24, 2019

Test run: FAILED

Summary: 1 of 1 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests

@0xc0170
Copy link
Contributor

0xc0170 commented May 26, 2019

unittests still need fixing

@0xc0170
Copy link
Contributor

0xc0170 commented May 27, 2019

Ci started

@mbed-ci
Copy link

mbed-ci commented May 27, 2019

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@mbed-ci
Copy link

mbed-ci commented May 27, 2019

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@mbed-ci
Copy link

mbed-ci commented May 27, 2019

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@mbed-ci
Copy link

mbed-ci commented May 27, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 7
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented May 28, 2019

Semaphore test timeouted.

@mbed-ci
Copy link

mbed-ci commented May 28, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 8
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@kjbracey
Introduce Semaphore::acquire methods
2fbbd9d 
Deprecate wait() in favour of acquire(), try_acquire(),
try_acquire_for() and try_acquire_until().

Brings Semaphore more into line with CMSIS-RTOS 2 (which uses "acquire"),
itself (as it has "release"), and other classes having "try", "try for"
and "try until".

Also steps away from vague "wait" term - the primary operation here is
to acquire the semaphore, and this will of course sleep.
@cmonr
Copy link
Contributor

cmonr commented May 28, 2019

CI restarted. Something with status reporting to the PR was stuck.

@mbed-ci
Copy link

mbed-ci commented May 28, 2019

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 9
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented May 28, 2019

CI internal error , restarted

@mbed-ci
Copy link

mbed-ci commented May 29, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 10
Build artifacts

@0xc0170 0xc0170 merged commit 9cc1caa into ARMmbed:master May 29, 2019
@d-kato d-kato mentioned this pull request Jun 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kjbracey @ciarmcom @0xc0170 @mbed-ci @cmonr @bulislaw @AnttiKauppila