Skip to content

K66F: Update SAI and SAI EDMA driver to SDK 2.5 #10605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2019
Merged

K66F: Update SAI and SAI EDMA driver to SDK 2.5 #10605

merged 1 commit into from
May 21, 2019

Conversation

sabharad
Copy link
Contributor

Description

SAI and SAI EDMA drivers in SDK 2.2 does not work with demo EDMA based audio loopback code from SDK 2.5. Tested the changes locally to confirm that updating SAI and SAI EDMA driver to SDK 2.5 fixes the issue. Driver code for SDK 2.5 was downloaded from https://mcuxpresso.nxp.com

Pull request type

[X ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mmahadevan108

@ciarmcom ciarmcom requested review from maclobdell, MarceloSalazar and a team May 17, 2019 07:00
@ciarmcom
Copy link
Member

@sabharad, thank you for your changes.
@MarceloSalazar @maclobdell @ARMmbed/mbed-os-maintainers please review.

mmahadevan108
mmahadevan108 approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@mmahadevan108 mmahadevan108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sabharad Thank you for your changes.

@mmahadevan108
Copy link
Contributor

@sabharad I am curious about your use-case. Can you share some details.

@sabharad
Copy link
Contributor Author

@mmahadevan108 The use case is to receive 16-bit 16 kHz mono audio from the DA7212 codec using I2S through EDMA. For some reason, SDK 2.2 drivers in mbed didn't work with SAI EDMA demo/example code from SDK 2.5.

@0xc0170
Copy link
Contributor

0xc0170 commented May 20, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented May 20, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage

@0xc0170 0xc0170 merged commit e4c6422 into ARMmbed:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@mmahadevan108 mmahadevan108 mmahadevan108 approved these changes

@maclobdell maclobdell Awaiting requested review from maclobdell

@MarceloSalazar MarceloSalazar Awaiting requested review from MarceloSalazar

Assignees
No one assigned
Labels
release-version: 5.13.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sabharad @ciarmcom @mmahadevan108 @0xc0170 @mbed-ci