STM32: Fix HSE/HSI clk source detection #1062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using online compiler (Keil) SystemInit (and systick stuff) is call before RW data is initialized, so static and global variables contains garbage. AHBPrescTable was one of these.
|
Thanks for the fixes. @bcostm Please review, this fix might go up to your sources. |
|
It's ok for me. I did the same thing in other Nucleo platforms and I thought it was done for all. Apparently not. |
|
Thanks @bcostm for review. |
0xc0170
added a commit
that referenced
this pull request
Apr 23, 2015
STM32 - Fix HSE/HSI clk source detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using online compiler (Keil), SystemInit (and systick stuff) are called
before RW data is initialized, so static and global variables contains
garbage. AHBPrescTable was one of these, used to set a (messed up) systick timeout for HSE to get ready.If it gets ready, no problem, that's why nucleo boards using HSE go straight.
SystemCoreClock variable is affected too, but situation has been already fixed:
I posted some more info here
http://developer.mbed.org/forum/bugs-suggestions/topic/5600/
Also ported the LSE longer timeout fix to other few platforms.