BLE HealthThermometerService: correct GATT characteristics #10640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per official specification, temperature measurement requires the GATT characteristic "INDICATE" instead of "NOTIFY". Full credits to Jean-Marc Jobin (@jmjobin on GitHub) for identifying the issue and proposing this fix.
|
@LDong-Arm, thank you for your changes. |
0xc0170
approved these changes
May 23, 2019
|
CI started |
paul-szczepanek-arm
approved these changes
May 23, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Issue ARMmbed/mbed-os-example-ble#53)
As per official specification (https://www.bluetooth.org/docman/handlers/downloaddoc.ashx?doc_id=238688), temperature measurement requires
the GATT characteristic "INDICATE" instead of "NOTIFY".
Full credits to Jean-Marc Jobin (@jmjobin on GitHub) for
identifying the issue and proposing this fix.
Pull request type
Reviewers
@donatieng @pan- @paul-szczepanek-arm