DO-NOT-MERGE: Test feature-watchdog branch after rebase #10657
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAL watchdog functionality will be implemented as two separate APIs. The reset reason API allows a user to detect the last system reset reason to identify if a Watchdog was triggered. The Watchdog API allows configuring and updating Watchdog timers on all boards. This commit defines the headers.
- Add preprocessor guard to watchdog api that errors if the reset reason api is not also implemented - Add RESET_REASON and WATCHDOG to K64F targets.json - Add watchdog reference implementation
- Fix typo in module comment - Redefine the default system behaviour in sleep mode - Guard K64F enableWait flag - Remove bit shifts from reset reason enum
- Change API to match C++ API throughout drivers - Amend HAL API documentation to be more specific
WDOG_Disable will suspend the watchdog until a reset is triggered instead of stopping it altogether. Deinit will disable it until it is reinitialized.
Limit MAX_TIMEOUT_MS to UINT32_MAX. Improve MAX_TIMEOUT_MS handling. Fix hal_watchdog_get_platform_features() returning .max_timeout = 0xfffffff8 instead of 0xffffffff.
Fix WATCHDOG_STATUS_INVALID_ARGUMENT for timeout values from 1 ms to 407 ms (fix inability to set prescaler bits to zero). Fix timeout <-> IWDG registers conversions. Fix read & write access to IWDG_PR and IWDG_RLR registers. Fix LSI RC frequency setting. Limit MAX_TIMEOUT_MS to UINT32_MAX.
Added a missing wait for the WCT window end. Without it, consecutive init() or stop() calls were ignored.
Relax time measurement margins for UBLOX_EVK_ODIN_W2.
|
@fkjagodzinski, thank you for your changes. |
|
Ci started |
Test run: FAILEDSummary: 3 of 7 test jobs failed Failed test jobs:
|
|
I removed the |
|
CI restarted |
Test run: FAILEDSummary: 1 of 7 test jobs failed Failed test jobs:
|
|
CI restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
@fkjagodzinski Ready for update? Let me know |
Yep, this rebased |
|
Rebased now, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains all changes from
feature-watchdogbranch rebased to currentmaster(c4cc9c4). We need to run CI checks, to make sure nothing has been broken during the rebase.Pull request type
Reviewers
@0xc0170 @jamesbeyond
Release Notes