Skip to content

Add IM880B as a new target platform #10677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

itziardelatorre
Copy link
Contributor

Description

Adds IM880B as a new platform.

The iM880B is a compact and low-cost radio module that operates in the unlicensed 868 MHz band and combines a powerful Cortex-M3 controller with the new LoRa® transceiver SX1272 of Semtech Corporation.
More details available at https://wireless-solutions.de/products/radiomodules/im880b-l.html

Please find attached the corresponding test results.
2019-05-24-TESTS_IM880B.zip

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from a team May 27, 2019 09:00
@ciarmcom
Copy link
Member

@itziardelatorre, thank you for your changes.
@ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-tools please review.


}

DynamicPinList::DynamicPinList(const PinList *pin_list)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe some changes here are already on master - bad rebase? Please review.

This file should not be part of this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. The "components/testing/" folder should not be changed. I am not sure where the changes come from...
Do you have any suggestion for me or could you continue with the other changes from this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not certain what you did. You can cleanup few ways.

You can remove files not changed by you and amend commit. As this is a new target, only few files needed, might be faster even to start from master and add new files and changes t oyour target.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to remove the unchanged files from my branch. Could you please check if this is ok now?
Thanks for your support.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not, still shown here as changed - file removal not related

0xc0170 and others added 3 commits May 27, 2019 14:47
…e/mbed-os into new_target_IM880B

# Conflicts:
#	targets/TARGET_STM/TARGET_STM32L1/TARGET_IM880B/device/TOOLCHAIN_ARM_MICRO/startup_stm32l151xba.S
#	targets/TARGET_STM/TARGET_STM32L1/TARGET_IM880B/device/TOOLCHAIN_ARM_STD/startup_stm32l151xba.S
#	targets/TARGET_STM/TARGET_STM32L1/TARGET_IM880B/device/TOOLCHAIN_GCC_ARM/startup_stm32l151xba.S
#	targets/TARGET_STM/TARGET_STM32L1/TARGET_IM880B/device/TOOLCHAIN_IAR/startup_stm32l151xba.S
@itziardelatorre itziardelatorre deleted the new_target_IM880B branch May 27, 2019 16:23
@0xc0170 0xc0170 mentioned this pull request Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants