-
Notifications
You must be signed in to change notification settings - Fork 3k
timeout_tests: do not call sleep from test thread #10698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timeout_tests: do not call sleep from test thread #10698
Conversation
Indeed, but I'm wondering if there is some subtle reason for the code being like that I'm missing. Following the |
Is this fixing a particular issue you've spotted? |
@kjbracey-arm I'm working on updating LP ticker implementation for STM targets. The changes have highlighted some dependencies to test updates. I'm pushing generic test updates first, and will reference them from the LP ticker change. According to your comment, should I replace wait by acquire in this PR ? |
Yes, |
#10701 is the change that triggered this test update |
This is up to scheduler to call sleep when threads are inactive. So the thread should simply wait for the semaphore for ever (or test timeout).
afe9881
to
19b843d
Compare
PR updated with new Semaphore API and verified on NUCLEO_L476RG
|
CI started while waiting for more reviews |
Test run: FAILEDSummary: 3 of 3 test jobs failed Failed test jobs:
|
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Description
This is up to scheduler to call sleep when threads are inactive.
So the thread should simply wait for the semaphore for ever (or test timeout).
Pull request type
Reviewers
@jeromecoutant @mprse
Release Notes