Add i2cee-driver to components #10711

geky · 2019-05-30T00:41:14Z

Description

From here #10495

I'm not going to be able to continue support what is the last external block device repo:
https://github.com/armmbed/i2cee-driver

So now it can either be brought into mbed-os like the rest of the block devices or someone else can support it out of tree. I've created this PR to help get it into mbed-os, since I think that would be the easiest option moving forward.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo, @pilotak, @rdrill, @ARMmbed/mbed-os-storage

Release Notes

Added i2cee-driver to components folder

…ails to compile

Adding explicit type conversion to overloaded log function

mBed online compiler fix + struct example

option to pass I2C object

- Needed new gcc-arm-embedded ppa - dist: Trusty did not allow apt-get update to work - test.py is no longer working as it once was - Needed to update pip versions

add missing get_type() from BlockDevice

…2806c11e0e05280c08db0b3ed6459b2d8dea2c' git-subtree-dir: components/storage/blockdevice/COMPONENT_I2CEE git-subtree-mainline: 9cc1caa git-subtree-split: d92806c

geky · 2019-05-30T00:44:35Z

Note: I don't know how much time I'm going to be able to spend maintaining this PR, so anyone is free to step in and update it.

ciarmcom · 2019-05-30T01:00:31Z

@geky, thank you for your changes.
@SeppoTakalo @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

pilotak · 2019-05-30T14:13:29Z

Thanks @geky it works the same as before with the lib outside the os.

0xc0170 · 2019-06-04T12:25:47Z

@ARMmbed/mbed-os-storage Please review this component addition

components/storage/blockdevice/COMPONENT_I2CEE/I2CEEBlockDevice.h

0xc0170 · 2019-08-14T09:21:02Z

CI restarted

mbed-ci · 2019-08-14T11:23:41Z

Test run: FAILED

Summary: 2 of 12 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_pdmc-test
jenkins-ci/mbed-os-ci_greentea-test

0xc0170 · 2019-08-14T11:25:55Z

pdmc can be ignored (invalid) but test shows components-storage-blockdevice-component_i2cee-tests-block_device-i2cee failure, please review

0xc0170 · 2019-08-20T10:58:31Z

@geky how can we move this forward - any assistance needed ?

0xc0170 · 2019-08-26T11:51:12Z

We are getting close to 5.14 code freeze, what shall we do with this PR?

pilotak · 2019-08-26T12:03:14Z

i have tested it physically on STM32F412ZG & STM32F303RE and it works perfectly it's just a matter of fixing the local test

bulislaw · 2019-08-28T11:19:06Z

@geky ping Also how is that tested? Do we have any docs in the handbook?

0xc0170 · 2019-08-29T07:07:33Z

@ARMmbed/mbed-os-storage If no update made by later today, we'll remove 5.14 label and move this to the next minor version. We are close to the 5.14 code freeze.

SeppoTakalo · 2019-08-29T08:38:04Z

Tests failed, because it still had I2CEE component in the K64F in the targets.json.
I removed it.
I don't know if any boards have this component on board, so it can automatically be tested in CI without adding extra components.

Tests provided seem OK for the component itself.

0xc0170 · 2019-08-29T09:21:45Z

CI started

0xc0170 · 2019-08-29T10:57:40Z

CI error, restarting

mbed-ci · 2019-08-29T10:58:03Z

Test run: FAILED

Summary: 2 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-GCC_ARM

0xc0170 · 2019-08-29T11:38:18Z

CI was restarted

mbed-ci · 2019-08-29T15:01:01Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

0xc0170 · 2019-08-29T15:13:58Z

Before we integrate, remaining question:

tests
documentation

@SeppoTakalo @geky

SeppoTakalo · 2019-08-30T11:01:44Z

Tests and documentation exist in the component folder itself.
No boards have this component in, so I'm relying only @pilotak 's report, that it works. Will not run actively in CI, but should probably be added in future.

Also, should be added to public documentation as well. I'll create ticket for my self, to do those in future.

pilotak · 2019-08-30T11:28:01Z

I can confim is it working fine, i have just tried it on STM32F412ZG

0xc0170 · 2019-08-30T11:45:35Z

Thanks for the updates.

Tests and documentation exist in the component folder itself.
Also, should be added to public documentation as well. I'll create ticket for my self, to do those in future.

@bulislaw Shall this component be integrated and handbook gets updated via separate ticket?

bulislaw · 2019-08-30T14:39:57Z

Yeah, lets do it.

geky and others added 16 commits February 14, 2017 11:29

Initial commit of the I2C EEPROM device

ec88f78

Updated to match API changes in mbed OS

f3272ad

Adding explicit type conversion to overloaded log function as ARMCC f…

bb61ee8

…ails to compile

Merge pull request #1 from ashok-rao/master

fdf0c2b

Adding explicit type conversion to overloaded log function

Renamed LICENSE -> LICENSE.md

69da721

Added support for Travis CI

2be4faf

Saving struct example

55ff892

Merge pull request ARMmbed#2 from pilotak/master

286a260

mBed online compiler fix + struct example

option to pass I2C object

8705669

requested changes

ffcc850

Changed I2C default instance to use placement new

b440d72

Merge pull request ARMmbed#4 from pilotak/master

3839563

option to pass I2C object

add missing get_type() from BlockDevice

0eb3475

Fixed travis issues

b87c0f6

- Needed new gcc-arm-embedded ppa - dist: Trusty did not allow apt-get update to work - test.py is no longer working as it once was - Needed to update pip versions

Merge pull request ARMmbed#5 from pilotak/master

d92806c

add missing get_type() from BlockDevice

Add 'components/storage/blockdevice/COMPONENT_I2CEE/' from commit 'd9…

51dd443

…2806c11e0e05280c08db0b3ed6459b2d8dea2c' git-subtree-dir: components/storage/blockdevice/COMPONENT_I2CEE git-subtree-mainline: 9cc1caa git-subtree-split: d92806c

geky mentioned this pull request May 30, 2019

i2cee-driver not part of components/storage #10495

Closed

ciarmcom requested review from SeppoTakalo and a team May 30, 2019 01:00

ciarmcom requested a review from a team May 30, 2019 01:00

ciarmcom added the needs: review label May 30, 2019

0xc0170 added the release-version: 5.14.0-rc1 label Jun 4, 2019

0xc0170 reviewed Jun 4, 2019

View reviewed changes

components/storage/blockdevice/COMPONENT_I2CEE/I2CEEBlockDevice.h Outdated Show resolved Hide resolved

SeppoTakalo approved these changes Jun 13, 2019

View reviewed changes

SeppoTakalo added needs: CI and removed needs: review labels Jun 13, 2019

0xc0170 added needs: CI and removed needs: work labels Aug 14, 2019

0xc0170 added needs: work and removed needs: CI labels Aug 14, 2019

Remove I2CEE component from K64F

3057ac1

0xc0170 added needs: CI and removed needs: work labels Aug 29, 2019

0xc0170 added ready for merge and removed needs: CI labels Aug 29, 2019

0xc0170 merged commit c74d67e into ARMmbed:master Aug 30, 2019

0xc0170 removed the ready for merge label Aug 30, 2019

Add i2cee-driver to components #10711

Add i2cee-driver to components #10711

Uh oh!

Conversation

geky commented May 30, 2019

Description

Pull request type

Reviewers

Release Notes

Uh oh!

geky commented May 30, 2019

Uh oh!

ciarmcom commented May 30, 2019

Uh oh!

pilotak commented May 30, 2019

Uh oh!

0xc0170 commented Jun 4, 2019

Uh oh!

Uh oh!

0xc0170 commented Aug 14, 2019

Uh oh!

mbed-ci commented Aug 14, 2019

Test run: FAILED

Uh oh!

0xc0170 commented Aug 14, 2019

Uh oh!

0xc0170 commented Aug 20, 2019

Uh oh!

0xc0170 commented Aug 26, 2019

Uh oh!

pilotak commented Aug 26, 2019

Uh oh!

bulislaw commented Aug 28, 2019

Uh oh!

0xc0170 commented Aug 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SeppoTakalo commented Aug 29, 2019

Uh oh!

0xc0170 commented Aug 29, 2019

Uh oh!

0xc0170 commented Aug 29, 2019

Uh oh!

mbed-ci commented Aug 29, 2019

Test run: FAILED

Uh oh!

0xc0170 commented Aug 29, 2019

Uh oh!

mbed-ci commented Aug 29, 2019

Test run: SUCCESS

Uh oh!

0xc0170 commented Aug 29, 2019

Uh oh!

SeppoTakalo commented Aug 30, 2019

Uh oh!

pilotak commented Aug 30, 2019

Uh oh!

0xc0170 commented Aug 30, 2019

Uh oh!

bulislaw commented Aug 30, 2019

Uh oh!

Uh oh!

0xc0170 commented Aug 29, 2019 •

edited

Loading