Skip to content

mbed-crypto: Automatically enable entropy injection #10722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2019
Merged

mbed-crypto: Automatically enable entropy injection #10722

merged 1 commit into from
Jun 4, 2019

Conversation

Patater
Copy link
Contributor

@Patater Patater commented May 31, 2019

Description

Automatically enable entropy injection when the NV Seed feature is
requested on PSA targets. Add a warning note describing the state of the
current implementation of the entropy injection API.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

0xc0170
0xc0170 approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading about the warning, it might already be there - is there a warning for this "incompatibility" ?

@0xc0170
Copy link
Contributor

0xc0170 commented May 31, 2019

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented May 31, 2019 •
edited
Loading

This should fix #10720

@teetak01 Does this fix the issue?

@Patater
mbed-crypto: Automatically enable entropy injection
4feb15c 
Automatically enable entropy injection when the NV Seed feature is
requested on PSA targets. Add a warning note describing the state of the
current implementation of the entropy injection API.

Fixes ARMmbed#10720
@Patater Patater force-pushed the auto-enable-psa-entropy-injection branch from 5ccf6d1 to 4feb15c Compare May 31, 2019 08:12
@Patater
Copy link
Contributor Author

Patater commented May 31, 2019

Reading about the warning, it might already be there - is there a warning for this "incompatibility" ?

There is not a warning, but you'll get a compilation failure if you try to use MBEDTLS_PSA_INJECT_ENTROPY without also opting out of other entropy sources explicitly with MBEDTLS_NO_DEFAULT_ENTROPY_SOURCES.

@0xc0170
Copy link
Contributor

0xc0170 commented May 31, 2019

@Patater Once "CI started" let us know if any new push. need to abort old CI and restart (I've noticed as browsing issues and found this new reference :) )

@0xc0170
Copy link
Contributor

0xc0170 commented May 31, 2019

CI job aborted, started new one

@mbed-ci
Copy link

mbed-ci commented May 31, 2019

Test run: FAILED

Summary: 6 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented May 31, 2019 •
edited
Loading

Looks like internal error, latest test runs were OK , restarting CI to confirm

armclang: error: unable to execute command: Terminated

@0xc0170
Copy link
Contributor

0xc0170 commented May 31, 2019

Ah no, aborted first run, All good, new run in progress 😌

teetak01
teetak01 approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@teetak01 teetak01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified to fix #10720

@mbed-ci
Copy link

mbed-ci commented May 31, 2019

Test run: FAILED

Summary: 2 of 7 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented May 31, 2019

Investigating the failures 😕

@0xc0170
Copy link
Contributor

0xc0170 commented May 31, 2019

@ARMmbed/mbed-os-test Need your help here to find failures

@mbed-ci
Copy link

mbed-ci commented May 31, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 3, 2019

Exporters restarted

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 3, 2019

Restarted again, due to license error

@OPpuolitaival
Copy link
Contributor

restarted export

bulislaw
bulislaw approved these changes Jun 4, 2019
View reviewed changes
Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for RC2. Should it be documented/mentioned in the handbook?

@0xc0170 0xc0170 merged commit b050a9d into ARMmbed:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@teetak01 teetak01 teetak01 approved these changes

@dgreen-arm dgreen-arm dgreen-arm approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.0-rc2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Patater @0xc0170 @mbed-ci @OPpuolitaival @bulislaw @teetak01 @dgreen-arm