Skip to content

Fix nrf52 memory pools #10733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 4, 2019
Merged

Fix nrf52 memory pools #10733

merged 5 commits into from
Jun 4, 2019

Conversation

pan-
Copy link
Member

@pan- pan- commented May 31, 2019

Description

Inclusion of #10666 has broken BLE on NRF52_DK. This patch also reduce the RAM necessary to run BLE on NRF52XXX targets.

  • NRF52_DK: 3.3K of RAM saved
  • NRF52840_DK: ~39K of RAM saved.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@LDong-Arm @paul-szczepanek-arm @donatieng

Release Notes

@ciarmcom
Copy link
Member

@pan-, thank you for your changes.
@donatieng @LDong-Arm @paul-szczepanek-arm @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 3, 2019

5.13.1 labeled (if this should be in the next RC, let us know)

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 3, 2019

5.13.1 labeled (if this should be in the next RC, let us know)

rc2 to address this issue in rc1

cc @adbridge

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 3, 2019

I started the CI job meanwhile

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 3, 2019

CI failed to check-out, we are investigating

cc @ARMmbed/mbed-os-test

Copy link
Contributor

@donatieng donatieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @pan-

@cmonr
Copy link
Contributor

cmonr commented Jun 3, 2019

CI restarted. S3 issues appear addressed.

@mbed-ci
Copy link

mbed-ci commented Jun 3, 2019

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR

Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for RC2

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 4, 2019

IAR reports build failures

ToolException: 
    l2cRegCb_t          regCb[L2C_COC_REG_MAX];   /* Registration control blocks */
                        ^
"/builds/ws/mbed-os-ci_build-IAR@4/mbed-os/features/FEATURE_BLE/targets/TARGET_CORDIO/stack/ble-host/sources/stack/l2c/l2c_coc.c",135  Error[Pe070]: incomplete type is not allowed

    l2cChanCb_t         chanCb[L2C_COC_CHAN_MAX]; /* Channel control blocks */
                        ^
"/builds/ws/mbed-os-ci_build-IAR@4/mbed-os/features/FEATURE_BLE/targets/TARGET_CORDIO/stack/ble-host/sources/stack/l2c/l2c_coc.c",137  Error[Pe070]: incomplete type is not allowed

    for (i = 0; i < L2C_COC_REG_MAX; i++, pCb++)

Please review

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 4, 2019

Does L2C_COC_CHAN_MAX need to be 0 ? It produces warnings in comparisons (against 0) plus incomplete type above

@pan-
Copy link
Member Author

pan- commented Jun 4, 2019

Looks like a value of 1 would be more adequate in this PR then.
A value of 0 should be allowed; let see what we can do after the release.

@paul-szczepanek-arm
Copy link
Member

does it matter though? we don't use that feature, I assume no allocations take place

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 4, 2019

Once updated, let us know, will restart testing

The stack doesn't cope with zero COC client or channel on IAR.
@pan-
Copy link
Member Author

pan- commented Jun 4, 2019

@0xc0170 Updated.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 4, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jun 4, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 7
Build artifacts

@0xc0170 0xc0170 merged commit fbc489e into ARMmbed:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants