-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix nrf52 memory pools #10733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nrf52 memory pools #10733
Conversation
@pan-, thank you for your changes. |
5.13.1 labeled (if this should be in the next RC, let us know) |
rc2 to address this issue in rc1 cc @adbridge |
I started the CI job meanwhile |
CI failed to check-out, we are investigating cc @ARMmbed/mbed-os-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @pan-
CI restarted. S3 issues appear addressed. |
Test run: FAILEDSummary: 1 of 7 test jobs failed Failed test jobs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for RC2
IAR reports build failures
Please review |
Does |
Looks like a value of 1 would be more adequate in this PR then. |
does it matter though? we don't use that feature, I assume no allocations take place |
Once updated, let us know, will restart testing |
The stack doesn't cope with zero COC client or channel on IAR.
@0xc0170 Updated. |
CI restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
Inclusion of #10666 has broken BLE on NRF52_DK. This patch also reduce the RAM necessary to run BLE on NRF52XXX targets.
Pull request type
Reviewers
@LDong-Arm @paul-szczepanek-arm @donatieng
Release Notes