ARMC6: Suppress "register deprecated" warning #10740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of target code, STM in particular, uses the `register` keyword, so it'll take a little while to clean up. In the interim, some builds are producing a lot of warnings. Suppress the warning for now, as `register` remains legal C++14 and C11, despite C++14 deprecating it. C++17 removes `register`, so code will need to be cleaned before any further C++ version update.
0xc0170
approved these changes
Jun 3, 2019
This was copied from the issue reported, I believe this would be good to have in rc2 cc @adbridge |
|
Yes, should have mentioned that - that's the justification for it being a "fix". (Plus some client test builds having warnings as errors?) |
jeromecoutant
approved these changes
Jun 3, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lots of target code, STM in particular, uses the
registerkeyword, soit'll take a little while to clean up. In the interim, some builds are
producing a lot of warnings. Suppress the warning for now, as
registerremains legal C++14 and C11, despite C++14 deprecating it.
C++17 removes
register, so code will need to be cleaned before anyfurther C++ version update.
Fixes #10717
Pull request type