Skip to content

Examples: enable more tests for examples #10749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2019
Merged

Examples: enable more tests for examples #10749

merged 1 commit into from
Jun 9, 2019

Conversation

jamesbeyond
Copy link
Contributor

Description

This enable more example tests, since the test case for following examples been/will be merged recently
ARMmbed/mbed-os-example-sd-driver#18
ARMmbed/mbed-os-example-devicekey#26
ARMmbed/mbed-os-example-kvstore#25
ARMmbed/mbed-os-example-nvstore#43
ARMmbed/mbed-os-example-filesystem#97

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@OPpuolitaival @mark-edgeworth

@ciarmcom ciarmcom requested review from mark-edgeworth, OPpuolitaival and a team June 3, 2019 19:00
@ciarmcom
Copy link
Member

ciarmcom commented Jun 3, 2019

@jamesbeyond, thank you for your changes.
@OPpuolitaival @mark-edgeworth @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

mark-edgeworth
mark-edgeworth approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@mark-edgeworth mark-edgeworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look straightforward, but I have not tried to run them.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 7, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 8, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 15539e0 into ARMmbed:master Jun 9, 2019
@jamesbeyond jamesbeyond deleted the example_test branch November 6, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OPpuolitaival OPpuolitaival OPpuolitaival approved these changes

@mark-edgeworth mark-edgeworth mark-edgeworth approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jamesbeyond @ciarmcom @0xc0170 @mbed-ci @OPpuolitaival @mark-edgeworth @adbridge