Skip to content

TARGET_TT:Setting wisely pin mode for TT_M3HQ. #10751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2019
Merged

TARGET_TT:Setting wisely pin mode for TT_M3HQ. #10751

merged 1 commit into from
Jun 9, 2019

Conversation

ThunderSoft123
Copy link
Contributor

Description

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested a review from a team June 4, 2019 07:00
@ciarmcom
Copy link
Member

ciarmcom commented Jun 4, 2019

@ThunderSoft123, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to align this to our coding style in separate PR.

If you run astyle on pinmap.c it would find these.

@ThunderSoft123
Copy link
Contributor Author

@0xc0170 Do you wish me to change coding style with tool astyle?

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 4, 2019

@0xc0170 Do you wish me to change coding style with tool astyle?

Yes, send it via new PR please

@ThunderSoft123
Copy link
Contributor Author

@0xc0170 Can you provide an instance?

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 7, 2019

Ci started

@0xc0170 Can you provide an instance?

What is needed?

@mbed-ci
Copy link

mbed-ci commented Jun 8, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 5581da5 into ARMmbed:master Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ThunderSoft123 @ciarmcom @0xc0170 @mbed-ci @adbridge