Skip to content

hal_qspi_test: undo buggy code #10755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2019
Merged

hal_qspi_test: undo buggy code #10755

merged 1 commit into from
Jun 5, 2019

Conversation

maciejbocianski
Copy link
Contributor

Removes buggy code introduced to hal_qspi_test by PR #10435
in commit:
Added support for QSPI to Cypress Boards a8570ff

This PR Fixes following issues:
#10730
#10728

@cy-opm could you retest Cypress Boards with these changes

Description

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@0xc0170
@cy-opm

Release Notes

@maciejbocianski
hal_qspi_test: undo buggy code
90fbab0 
Remove some buggy code introduced to hal_qspi_test by PR ARMmbed#10435
Added support for QSPI to Cypress Boards
a8570ff
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 4, 2019

Is this partial revert ? Changes touching the tests are being reverted here?

@maciejbocianski
Copy link
Contributor Author

Yes it's partial, but rest of changes looks OK.
It adds extra testcases for 1I4O write mode

0xc0170
0xc0170 approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new addition will need to be properly added this time 🙄

jeromecoutant
jeromecoutant approved these changes Jun 4, 2019
View reviewed changes
Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target platform_name test suite result elapsed_time (sec) copy_method
DISCO_L475VG_IOT01A-ARMC6 DISCO_L475VG_IOT01A tests-mbed_hal-qspi OK 36.92 default

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 4, 2019

Ci started

This was referenced Jun 4, 2019
Closed
Closed
@mbed-ci
Copy link

mbed-ci commented Jun 4, 2019

Test run: FAILED

Summary: 3 of 3 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 4, 2019

CI restarted , it was aborted

@mbed-ci
Copy link

mbed-ci commented Jun 4, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@maciejbocianski
Copy link
Contributor Author

maciejbocianski commented Jun 4, 2019 •
edited
Loading

Strange fail on EV_COG_AD3029LZ IAR looks not related, cannot even determine the reason
@0xc0170 can we restart CI ?

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 5, 2019

yes, will do

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 5, 2019

Nightly QSPI should be fixed !

@0xc0170 0xc0170 merged commit 2b354a4 into ARMmbed:master Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maciejbocianski @0xc0170 @mbed-ci @jeromecoutant