Workarounds for GAP advertising issues on Cordio #10772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, extended advertising parameters failed to be set during BLE initialisation when the stack was not ready. To work around this, we delay it to the first use of useVersionTwoAPI.
Due to some issue in Cordio link layer, advertising data does not take effect unless we set it (or set it again) after advertising parameters are set.
|
@LDong-Arm, thank you for your changes. |
paul-szczepanek-arm
approved these changes
Jun 6, 2019
0xc0170
approved these changes
Jun 7, 2019
pan-
approved these changes
Jun 7, 2019
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
LDong-Arm
added a commit
to LDong-Arm/mbed-os
that referenced
this pull request
Mar 31, 2020
This is based on (and supercedes) PR ARMmbed#10772. As the switches between old and new APIs do not exist anymore, we create a function for legacy advertising set creation.
LDong-Arm
added a commit
to LDong-Arm/mbed-os
that referenced
this pull request
Apr 3, 2020
This is based on (and supercedes) PR ARMmbed#10772. As the switches between old and new APIs do not exist anymore, we create a function for legacy advertising set creation.
LDong-Arm
added a commit
to LDong-Arm/mbed-os
that referenced
this pull request
Apr 6, 2020
This is based on (and supercedes) PR ARMmbed#10772. As the switches between old and new APIs do not exist anymore, we create a function for legacy advertising set creation.
LDong-Arm
added a commit
to LDong-Arm/mbed-os
that referenced
this pull request
Apr 17, 2020
This is based on (and supercedes) PR ARMmbed#10772. As the switches between old and new APIs do not exist anymore, we create a function for legacy advertising set creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to possible issues in Cordio link layer, GAP payload is not advertised if it is set before adverting parameters is. This impacts both new and legacy APIs.
Workarounds:
API v1: Force setAdvertisingData during startAdvertising, to ensure data gets advertised.
API v2: Delay setExtendedAdvertisingParameters to the first use of API v2. Previously this was done during GenericGap initialisation and always failed because the stack was not ready.
This PR depends on #10709 since nRF52/nRF52840 on Cordio stack is needed in order to reproduce the issue (and test this PR).
(Thanks to @pan- for help with debugging and proposed workarounds.)
Pull request type
Reviewers
@pan- @paul-szczepanek-arm