Add mbed app shield test for the SPI display and improve the armcc regex support to support armsm output #1078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| "id": "MBED_35", "description": "SPI C12832 display", | ||
| "source_dir": join(TEST_DIR, "mbed", "spi_C12832"), | ||
| "dependencies": [MBED_LIBRARIES, TEST_MBED_LIB, join(PERIPHERALS, 'C12832')], |
There was a problem hiding this comment.
About adding new libraries, you should at least:
- Define new library (
'C12832') metadata inlibraries.py. - Use
paths.pyto define library constant & paths to your new library (sources and headers), note path to library and its constant (e.g.CPPUTEST_LIBRARY) ends with_LIBRARY. In your case it should beC12832_LIBRARY:
"dependencies": [MBED_LIBRARIES, TEST_MBED_LIB, join(PERIPHERALS, C12832_LIBRARY)],
Note: There is another option, you can just make C12832 drivers' code as part of this test (maybe not the best idea).
There was a problem hiding this comment.
None of the libraries under "libraries\tests\peripherals" is using the definitions as per your post. In fact I was using "ADXL345" as example how to add new libraries. Fancy changing all the other libraries so there is good example how it must be done? :)
There was a problem hiding this comment.
My bad!
You are right, I forgot about peripheral libs. You've followed correct way to do it :)
0xc0170
added a commit
that referenced
this pull request
May 4, 2015
Tests: mbed app shield test for the SPI display and improve the armcc regex support to support armsm output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.