GR_LYCHEE,RZ_A1H,VK_RZ_A1H: Fix greentea test failure with ARMC6 #10782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
How do we know 380 bytes is sufficient? I am missing information in the commit.
Without going in details how are functions implemented, how is adding |
I actually tried running the test. It failed at 360 bytes and succeeded at 370 bytes. It added 10 bytes as a margin and became 380 bytes.
It is a function to initialize the argument regset. All macro values used in the function are 0. static void clear_spimd_reg(volatile st_spibsc_spimd_reg_t * regset)
{
/* ---- command ---- */
regset->cde = SPIBSC_OUTPUT_DISABLE;
regset->cdb = SPIBSC_1BIT;
regset->cmd = 0x00;
/* ---- optional command ---- */
regset->ocde = SPIBSC_OUTPUT_DISABLE;
regset->ocdb = SPIBSC_1BIT;
regset->ocmd = 0x00;
/* ---- address ---- */
regset->ade = SPIBSC_OUTPUT_DISABLE;
regset->addre = SPIBSC_SDR_TRANS; /* SDR */
regset->adb = SPIBSC_1BIT;
regset->addr = 0x00000000;
/* ---- option data ---- */
regset->opde = SPIBSC_OUTPUT_DISABLE;
regset->opdre = SPIBSC_SDR_TRANS; /* SDR */
regset->opdb = SPIBSC_1BIT;
regset->opd[0] = 0x00; /* OPD3 */
regset->opd[1] = 0x00; /* OPD2 */
regset->opd[2] = 0x00; /* OPD1 */
regset->opd[3] = 0x00; /* OPD0 */
/* ---- dummy cycle ---- */
regset->dme = SPIBSC_DUMMY_CYC_DISABLE;
regset->dmdb = SPIBSC_1BIT;
regset->dmcyc = SPIBSC_DUMMY_1CYC;
/* ---- data ---- */
regset->spide = SPIBSC_OUTPUT_DISABLE;
regset->spidre = SPIBSC_SDR_TRANS; /* SDR */
regset->spidb = SPIBSC_1BIT;
/* ---- Others ---- */
regset->sslkp = SPIBSC_SPISSL_NEGATE; /* SPBSSL level */
regset->spire = SPIBSC_SPIDATA_DISABLE; /* read enable/disable */
regset->spiwe = SPIBSC_SPIDATA_DISABLE; /* write enable/disable */
}[Test result] |
0xc0170
approved these changes
Jun 7, 2019
|
Rerunning CI to ensure results are not stale |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for issue #10729
Fix the following test failures.
tests-mbed_drivers-crc
The task stack is insufficient. It succeeded when it increased from 320 bytes to 380 bytes.
Change file : mbed-os\TESTS\mbed_drivers\crc\main.c
tests-mbed_drivers-flashiap and tests-mbed_hal-flash
The flash driver process needs to be located in RAM, but the function "clear_spimd_reg()" has been replaced with "memset()" located in ROM due to the effect of optimization.
The function "clear_spimd_reg()" has been changed to not be affected by optimization.
Change file : mbed-os\targets\TARGET_RENESAS\TARGET_RZ_A1XX\flash.c
Pull request type
Reviewers
Release Notes