ns_list: avoid UINT_FAST8_MAX (fix ARM C 5 builds) #10809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent compilation issues when someone has included <stdint.h> before a header file that needs to include <ns_list.h>. Some toolchains like ARM C 5 will not provide UINT_FAST8_MAX in C++ unless __STDC_LIMIT_MACROS is defined, and if this was not defined the first time <stdint.h> was included, it's too late. We can get the maximum value for our unsigned list offset by casting -1 to it, thanks to modulo arithmetic.
Merged
|
This fixes the remaining ARMC5 issue. Thank you very much for quick response. |
|
Ci started |
|
@TeroJaasko I tagged you for review , I know you commented already but could you approve the review please ? |
TeroJaasko
approved these changes
Jun 11, 2019
0xc0170
approved these changes
Jun 12, 2019
Test run: FAILEDSummary: 1 of 7 test jobs failed Failed test jobs:
|
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent compilation issues when someone has included <stdint.h> before a header file that needs to include <ns_list.h>.
Some toolchains like ARM C 5 will not provide
UINT_FAST8_MAXin C++ unless__STDC_LIMIT_MACROSis defined, and if this was not defined the first time <stdint.h> was included, it's too late.We can get the maximum value for our unsigned list offset by casting -1 to it, thanks to modulo arithmetic.
Pull request type
Reviewers
@artokin, @TeroJaasko