Skip to content

Cellular: fix athandler to use correct timeout in case of multiple urc's #10812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2019
Merged

Cellular: fix athandler to use correct timeout in case of multiple urc's #10812

merged 1 commit into from
Jun 19, 2019

Conversation

jarvte
Copy link
Contributor

@jarvte jarvte commented Jun 12, 2019

Description

Start time was not updated when multiple urc's were found and so timeout was set to zero. Now that start time is updated, timeout is correct.
Fixes issue #10549

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mirelachirica

Release Notes

Cellular: fix athandler to use correct timeout in case of multiple urc's
6b11ca1 
Start time was not updated when multiple urc's were found and so timeout
was set to zero. Now that start time is updated, timeout is correct.
@ciarmcom ciarmcom requested review from mirelachirica and a team June 12, 2019 09:00
@ciarmcom
Copy link
Member

@jarvte, thank you for your changes.
@mirelachirica @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@mirelachirica mirelachirica mentioned this pull request Jun 12, 2019
Closed
@mbed-ci
Copy link

mbed-ci commented Jun 13, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@jarvte
Copy link
Contributor Author

jarvte commented Jun 14, 2019

Greentea failures not related to this pr.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 14, 2019

Restarted

@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 15, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@adbridge
Copy link
Contributor

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jun 18, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@adbridge adbridge merged commit 3764030 into ARMmbed:master Jun 19, 2019
@jarvte jarvte deleted the fix_multiple_urc_athander branch January 17, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@mirelachirica mirelachirica mirelachirica approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jarvte @ciarmcom @mbed-ci @0xc0170 @adbridge @SeppoTakalo @AnttiKauppila @mirelachirica