Skip to content

Cellular: cellular socket flags updated #10840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2019
Merged

Cellular: cellular socket flags updated #10840

merged 1 commit into from
Jul 1, 2019

Conversation

mudassar-ublox
Copy link
Contributor

Description

Cellular socket flags updated on socket create and data received on socket.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@mudassar-ublox mudassar-ublox mentioned this pull request Jun 17, 2019
Closed
@ciarmcom ciarmcom requested review from a team June 17, 2019 07:00
@ciarmcom
Copy link
Member

@mudassar-ublox, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@adbridge adbridge changed the title Cellualr: cellular socket flags updated Cellular: cellular socket flags updated Jun 20, 2019
@adbridge
Copy link
Contributor

@mudassar-ublox looks like we have a conflict that may need a rebase please?

@mudassar-ublox
Copy link
Contributor Author

PR is rebased to latest master, please review now.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 28, 2019

Looks fine, Travis restarted, CI started

@mbed-ci
Copy link

mbed-ci commented Jun 28, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test

@0xc0170 0xc0170 merged commit 60d047c into ARMmbed:master Jul 1, 2019
@pilotak
Copy link
Contributor

pilotak commented Jul 1, 2019

@mudassar-ublox could you please give an example how to retreive socket->rx_avail when I use TCPSocket above CellularContext

@pilotak pilotak mentioned this pull request Jul 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adbridge adbridge adbridge approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mudassar-ublox @ciarmcom @adbridge @0xc0170 @mbed-ci @pilotak @AnttiKauppila