Skip to content

MbedCRC doxygen fixes #10846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2019
Merged

MbedCRC doxygen fixes #10846

merged 3 commits into from
Jun 25, 2019

Conversation

bulislaw
Copy link
Member

Description

Fix doxygen for MbedCRC class so that description is associated with the class not with random variable. Also document all the default polynomials and theory of operation.

Pull request type

[ X ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AnotherButler

@ciarmcom ciarmcom requested review from AnotherButler and a team June 17, 2019 13:00
@ciarmcom
Copy link
Member

@bulislaw, thank you for your changes.
@AnotherButler @ARMmbed/mbed-os-core @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-maintainers please review.

Review changes, and edit file while I'm at it.
Copy link
Contributor

@AnotherButler AnotherButler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍

@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 23, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
  • jenkins-ci/mbed-os-ci_dynamic-memory-usage

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 24, 2019

2 failed jobs restarted (internal error)

@0xc0170 0xc0170 merged commit 6229322 into ARMmbed:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants