Skip to content

Make the sys_arch_protect() mutex be recursive. #10861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2019
Merged

Make the sys_arch_protect() mutex be recursive. #10861

merged 1 commit into from
Jul 1, 2019
+1 −0

Conversation

pauluap
Copy link

@pauluap pauluap commented Jun 18, 2019 •
edited
Loading

Description

Fixes #9744

Appears to be a lwIP porting bug. Comments in our porting layer say:

This function should support recursive calls from the same task or interrupt. In other words, sys_arch_protect() could be called while already protected.

Pull request type

[x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from a team June 18, 2019 23:00
@ciarmcom
Copy link
Member

@pauluap, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

VeijoPesonen
VeijoPesonen reviewed Jun 19, 2019
View reviewed changes
Copy link
Contributor

@VeijoPesonen VeijoPesonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should tell this is a bugfix and provide the reasoning behind the change.

Make the sys_arch_protect() mutex be recursive.
91402f4 
Fixes ARMmbed#9744

Appears to be a lwIP porting bug. Comments in our porting layer say:

    This function should support recursive calls from the same task or interrupt. In other words, sys_arch_protect() could be called while already protected.
@pauluap pauluap force-pushed the lwip_use_recursive_mutex branch from 1df9e06 to 91402f4 Compare June 20, 2019 04:50
@pauluap
Copy link
Author

pauluap commented Jun 20, 2019

Allright, updated the comment, is this sufficient?

@adbridge
Copy link
Contributor

adbridge commented Jun 21, 2019 •
edited
Loading

@pauluap we would normally expect a bit more detail in the Description than just :
'Fixes xxxx'
A reason for the change would also be good. Text should also go after the Description line, not before. Thanks

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 28, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 28, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test

@0xc0170 0xc0170 merged commit 755c6b8 into ARMmbed:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@VeijoPesonen VeijoPesonen VeijoPesonen approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UDPSocket::join_multicast_group - apparent deadlock in do_memp_malloc_pool
6 participants
@pauluap @ciarmcom @adbridge @0xc0170 @mbed-ci @VeijoPesonen