Skip to content

TLSSocket: print certificate info only when tracing is enabled #10864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2019
Merged

TLSSocket: print certificate info only when tracing is enabled #10864

merged 1 commit into from
Jun 26, 2019

Conversation

anttiylitokola
Copy link
Contributor

Description

Print certificate information only when tracing is enabled otherwise it will bring more than 3K of extra flash.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@yogpan01

TLSSocket: print certificate info only when tracing is enabled
b5661ff 
Flagging these functions out will reduce flash size more than 3k.
@ciarmcom ciarmcom requested review from yogpan01 and a team June 19, 2019 09:00
@ciarmcom
Copy link
Member

@anttiylitokola, thank you for your changes.
@yogpan01 @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 23, 2019

Test run: FAILED

Summary: 3 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
  • jenkins-ci/mbed-os-ci_cloud-client-test
  • jenkins-ci/mbed-os-ci_dynamic-memory-usage

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 24, 2019

There was internal CI error, will restart once RC4 passes.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 25, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jun 25, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 68c3dc6 into ARMmbed:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjbracey kjbracey kjbracey approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@yogpan01 yogpan01 Awaiting requested review from yogpan01

Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@anttiylitokola @ciarmcom @adbridge @mbed-ci @0xc0170 @kjbracey @AnttiKauppila