Cellular: Ublox cellular context activation updated for C030_R412M #10877

mudassar-ublox · 2019-06-20T12:59:00Z

Description

UBLOX_C030_R412M cellular context activation updated for 2G. Updated RAT and AUTH configuration and other minor fixes.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

mudassar-ublox · 2019-06-20T12:59:22Z

@fahim-ublox @wajahat-ublox

ciarmcom · 2019-06-20T13:00:36Z

@mudassar-ublox, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

0xc0170 · 2019-06-28T13:26:40Z

Please fix astyle

mudassar-ublox · 2019-07-09T07:21:25Z

Astyle issue fixed and update PR as well, updated RAT and AUTH configurations. Please review.

artokin · 2019-07-09T07:26:39Z

@mudassar-ublox , would you please resolve the conflicts?

mudassar-ublox · 2019-07-09T10:04:49Z

@mudassar-ublox , would you please resolve the conflicts?

Conflict resolved.

0xc0170 · 2019-07-09T11:46:53Z

features/cellular/TESTS/api/cellular_network/main.cpp

@@ -155,6 +155,11 @@ static void test_other()
 {
    TEST_ASSERT(nw->get_3gpp_error() == 0);

+#ifdef TARGET_UBLOX_C030
+    nsapi_error_t err = nw->detach();


test should not contain #ifdef target, either works or not - handling this should be in the target code or driver.

Removed target specific code.

will it work (test pass) ?

Yes, handled in driver, return UNSUPPORTED if try to change RAT while in attach state.

0xc0170 · 2019-07-09T11:48:45Z

@ARMmbed/mbed-os-wan Please review

0xc0170 · 2019-07-10T10:04:07Z

Please review astyle failures

mudassar-ublox · 2019-07-10T11:22:10Z

Please review astyle failures

Please review, Astyle issue fixed. AriParkkila once shared asytle software for styling and I used that for styling. Seems its not correct software for it as now getting style issue on my PR's.
Also attaching cellular tests result logs.
R412M_Cellular_Test.txt

0xc0170 · 2019-07-10T12:08:18Z

@mudassar-ublox use astylerc as config for astyle, it has all needed

wajahat-abbas · 2019-07-12T09:54:42Z

@mudassar-ublox This fixes #9711 correct?

mudassar-ublox · 2019-07-12T12:52:52Z

@mudassar-ublox This fixes #9711 correct?

Not sure about this issue but now we can set auth type from main application, set_authentication_type. Let me ask on ticket #9711.

mudassar-ublox · 2019-07-16T09:52:20Z

Anything else required on this PR?

mudassar-ublox · 2019-07-22T05:30:13Z

@0xc0170 any update on this PR?

SeppoTakalo · 2019-07-24T12:32:47Z

@mudassar-ublox Please don't merge from master into your branch. Makes review and history really annoying.
Please remove the merge commit and rebase your branch on top of master.

mudassar-ublox · 2019-07-24T13:06:14Z

Issue fixed and re-based branch to latest master. Please review now.

SeppoTakalo · 2019-07-26T08:00:49Z

Thanks.
CI tests started now.

mbed-ci · 2019-07-26T09:46:00Z

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-IAR

SeppoTakalo · 2019-07-29T14:35:04Z

@mudassar-ublox Please check the build failures

2019-07-26T08:11:22.017Z] [2019-07-26T08:11:22.017Z] [Warning] UBLOX_AT_CellularNetwork.cpp@101,13: 'wait_ms' is deprecated: 'wait_ms' is deprecated in favor of explicit sleep functions. To sleep, 'wait_ms' should be replaced by 'ThisThread::sleep_for' (C++) or 'thread_sleep_for' (C). If you wish to wait (without sleeping), call 'wait_us'. 'wait_us' is safe to call from ISR context. [since mbed-os-5.14] [-Wdeprecated-declarations]

[2019-07-26T08:11:22.017Z] [2019-07-26T08:11:22.017Z] Compile [ 10.9%]: UBLOX_PPP.cpp

[2019-07-26T08:11:22.017Z] [2019-07-26T08:11:22.017Z] Compile [ 11.0%]: sn_coap_builder.c

[2019-07-26T08:11:22.017Z] [2019-07-26T08:11:22.017Z] Compile [ 11.1%]: sn_coap_protocol.c

[2019-07-26T08:11:22.018Z] [2019-07-26T08:11:22.017Z] Compile [ 11.3%]: UBLOX_N2XX.cpp

[2019-07-26T08:11:22.018Z] [2019-07-26T08:11:22.018Z] Compile [ 11.4%]: UBLOX_AT_CellularStack.cpp

[2019-07-26T08:11:22.018Z] [2019-07-26T08:11:22.018Z] Compile [ 11.5%]: stoip4.c

[2019-07-26T08:11:22.018Z] [2019-07-26T08:11:22.018Z] Compile [ 11.6%]: UBLOX_AT_CellularContext.cpp

[2019-07-26T08:11:22.018Z] [2019-07-26T08:11:22.018Z] [Error] UBLOX_AT_CellularContext.cpp@87,22: use of undeclared identifier 'define_context'

[2019-07-26T08:11:22.018Z] [2019-07-26T08:11:22.018Z] Failed to build library

…AUTH configuration

mudassar-ublox · 2019-07-31T13:03:17Z

@SeppoTakalo Build failure fixed. Please review now.

mbed-ci · 2019-08-01T16:22:23Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

0xc0170 · 2019-08-09T14:57:56Z

Moving to 5.14 due to conflicts in cellular framework files . If needed earlier, PR for 5.13 branch that we could cherry pick would be good if needed earlier.
I tried to manually resolved but did not manage to get the changes from master from this changeset.

ciarmcom requested review from a team June 20, 2019 13:00

ciarmcom added the needs: review label Jun 20, 2019

mudassar-ublox force-pushed the ubx_context_activation branch from 782617b to 8851238 Compare June 21, 2019 07:18

0xc0170 added needs: work and removed needs: review labels Jun 28, 2019

mudassar-ublox force-pushed the ubx_context_activation branch from 8851238 to dd568a6 Compare July 9, 2019 07:16

artokin added needs: review needs: work and removed needs: work needs: review labels Jul 9, 2019

mudassar-ublox force-pushed the ubx_context_activation branch from dd568a6 to a9f7909 Compare July 9, 2019 10:03

0xc0170 reviewed Jul 9, 2019

View reviewed changes

AnttiKauppila approved these changes Jul 10, 2019

View reviewed changes

mudassar-ublox force-pushed the ubx_context_activation branch from 1f9dae7 to 1ec6117 Compare July 11, 2019 04:35

mudassar-ublox mentioned this pull request Jul 12, 2019

UBLOX_AT_CellularContext appears to use wrong authentication for Stream sims #9711

Closed

mudassar-ublox force-pushed the ubx_context_activation branch from e20b269 to ee3e8e6 Compare July 24, 2019 12:58

mudassar-ublox force-pushed the ubx_context_activation branch from ee3e8e6 to ae4edde Compare July 26, 2019 06:06

SeppoTakalo approved these changes Jul 26, 2019

View reviewed changes

SeppoTakalo added needs: CI and removed needs: work labels Jul 26, 2019

SeppoTakalo added needs: work and removed needs: CI labels Jul 29, 2019

UBLOX cellular context activation updated for C030_R412M and updated …

6cd6017

…AUTH configuration

mudassar-ublox force-pushed the ubx_context_activation branch from ae4edde to 6cd6017 Compare July 30, 2019 07:20

SeppoTakalo added needs: CI and removed needs: work labels Aug 1, 2019

SeppoTakalo approved these changes Aug 2, 2019

View reviewed changes

SeppoTakalo added ready for merge release-version: 5.13.3 and removed needs: CI labels Aug 2, 2019

SeppoTakalo merged commit 4a1f00a into ARMmbed:master Aug 2, 2019

SeppoTakalo removed the ready for merge label Aug 2, 2019

pilotak mentioned this pull request Aug 6, 2019

Ublox cellular: broken support for custom board #11170

Closed

0xc0170 added release-version: 5.14.0-rc1 and removed release-version: 5.13.3 labels Aug 9, 2019

Cellular: Ublox cellular context activation updated for C030_R412M #10877

Cellular: Ublox cellular context activation updated for C030_R412M #10877

Uh oh!

Conversation

mudassar-ublox commented Jun 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Reviewers

Release Notes

Uh oh!

mudassar-ublox commented Jun 20, 2019

Uh oh!

ciarmcom commented Jun 20, 2019

Uh oh!

0xc0170 commented Jun 28, 2019

Uh oh!

mudassar-ublox commented Jul 9, 2019

Uh oh!

artokin commented Jul 9, 2019

Uh oh!

mudassar-ublox commented Jul 9, 2019

Uh oh!

0xc0170 Jul 9, 2019

Choose a reason for hiding this comment

Uh oh!

mudassar-ublox Jul 9, 2019

Choose a reason for hiding this comment

Uh oh!

0xc0170 Jul 9, 2019

Choose a reason for hiding this comment

Uh oh!

mudassar-ublox Jul 10, 2019

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jul 9, 2019

Uh oh!

0xc0170 commented Jul 10, 2019

Uh oh!

mudassar-ublox commented Jul 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Jul 10, 2019

Uh oh!

wajahat-abbas commented Jul 12, 2019

Uh oh!

mudassar-ublox commented Jul 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mudassar-ublox commented Jul 16, 2019

Uh oh!

mudassar-ublox commented Jul 22, 2019

Uh oh!

SeppoTakalo commented Jul 24, 2019

Uh oh!

mudassar-ublox commented Jul 24, 2019

Uh oh!

SeppoTakalo commented Jul 26, 2019

Uh oh!

mbed-ci commented Jul 26, 2019

Test run: FAILED

Uh oh!

SeppoTakalo commented Jul 29, 2019

Uh oh!

mudassar-ublox commented Jul 31, 2019

Uh oh!

mbed-ci commented Aug 1, 2019

Test run: SUCCESS

Uh oh!

0xc0170 commented Aug 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mudassar-ublox commented Jun 20, 2019 •

edited

Loading

mudassar-ublox commented Jul 10, 2019 •

edited

Loading

mudassar-ublox commented Jul 12, 2019 •

edited

Loading

0xc0170 commented Aug 9, 2019 •

edited

Loading