[HAL][KSDK] Fix issue with KSDK SPI timing #1088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on the format by default the Freescale SPI peripheral does not give proper delay between SPI transfers. So code has been added which sets half a period delay between SPI transfers.
Even though it does not actually toggle the CS signal, we can also use the delay to CS toggle to get proper waveforms. This also fixes SPI in mode 3.
|
Switched delay type, now it should also solve #968 |
|
Thanks Minion 😄 |
0xc0170
added a commit
that referenced
this pull request
May 4, 2015
KSDK - Fix issue with KSDK SPI timing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the format by default the Freescale SPI peripheral does not
give proper delay between SPI transfers. So code has been added which
sets half a period delay between SPI transfers.
See the following picture:
http://static.tweakers.net/ext/f/gAoTfuAGPXuMgtqbCm34UOJ9/full.png
This is related to #840 (you can see the same clock issue in the pic there). This issue: #968 does not seem to be solved by this, in mode 3 the MOSI line goes up stil way too soon.