Skip to content

Pullup/pulldown wrong configuration in STM32F1 mcu #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Pullup/pulldown wrong configuration in STM32F1 mcu #1089

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d1afb8
Updated pinmap.c in target_stm32f1
raulMrello May 4, 2015
dd27e29
Merge remote-tracking branch 'upstream/master' into pinmap_stm32f1
raulMrello May 4, 2015
88e7489
Merge remote-tracking branch 'upstream/master' into pinmap_stm32f1
raulMrello May 4, 2015
ca6d764
Merge remote-tracking branch 'upstream/master' into pinmap_stm32f1
raulMrello May 4, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions libraries/mbed/targets/hal/TARGET_STM/TARGET_STM32F1/pinmap.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,12 +177,22 @@ void pin_mode(PinName pin, PinMode mode)
if (pin_index < 8) {
if ((gpio->CRL & (0x03 << (pin_index * 4))) == 0) { // MODE bits = Input mode
gpio->CRL |= (0x08 << (pin_index * 4)); // Set pull-up / pull-down
gpio->CRL &= ~(0x08 << ((pin_index * 4)-1)); // ENSURES GPIOx_CRL.CNFx.bit0 = 0
}
} else {
if ((gpio->CRH & (0x03 << ((pin_index % 8) * 4))) == 0) { // MODE bits = Input mode
gpio->CRH |= (0x08 << ((pin_index % 8) * 4)); // Set pull-up / pull-down
gpio->CRH &= ~(0x08 << (((pin_index % 8) * 4)-1)); // ENSURES GPIOx_CRH.CNFx.bit0 = 0
}
}
// Now it's time to setup properly if pullup or pulldown. This is done in ODR register:
// set pull-up => bit=1, set pull-down => bit = 0
if(mode == PullUp){
gpio->ODR |= (0x01 << (pin_index)); // Set pull-up
}
else{
gpio->ODR &= ~(0x01 << (pin_index)); // Set pull-down
}
break;
case OpenDrain:
// Set open-drain for Output mode (General Purpose or Alternate Function)
Expand Down