Fix netconn_recv_tcp_pbuf ARMC6 linker error #10908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If "lwip.tcp-enabled" is set to false, ARMC6 compilation fails to error Error: L6218E: Undefined symbol netconn_recv_tcp_pbuf LWIP::socket_recv() is TCP socket specific method so implementation can be enabled only when LWIP_TCP flag is set.
|
@kivaisan, thank you for your changes. |
kjbracey
approved these changes
Jun 27, 2019
0xc0170
approved these changes
Jun 28, 2019
|
Ci started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If "lwip.tcp-enabled" is set to false, ARMC6 compilation fails to linker error
Error: L6218E: Undefined symbol netconn_recv_tcp_pbuf
LWIP::socket_recv() is TCP socket specific method so implementation can be
enabled only when LWIP_TCP flag is set.
Fixes the compilation bug introduced in PR #10807.
Pull request type
Reviewers
@kjbracey-arm
Release Notes