Skip to content

Doubled ATHandler's BUFF_SIZE #10925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2019
Merged

Doubled ATHandler's BUFF_SIZE #10925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c315672
Doubled ATHandler's BUFF_SIZE
Jul 1, 2019
369e2d5
Fixed unittests
Jul 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions UNITTESTS/features/cellular/framework/AT/athandler/athandlertest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,15 +570,15 @@ TEST_F(TestATHandler, test_ATHandler_read_bytes)
mbed_poll_stub::int_value = 1;;

// Read 5 bytes
EXPECT_TRUE(5 == at.read_bytes(buf, 5));
EXPECT_EQ(5, at.read_bytes(buf, 5));
EXPECT_TRUE(!memcmp(buf, table1, 5));
// get_char triggered above should have filled in the whole reading buffer(fill_buffer())
EXPECT_TRUE(filehandle_stub_table_pos == (strlen(table1) - 1));
EXPECT_EQ(filehandle_stub_table_pos, (strlen(table1)));
// Read another 8 bytes
EXPECT_TRUE(8 == at.read_bytes(buf, 8) && !memcmp(buf, table1 + 5, 8));
// Reading more than the 4 bytes left -> ERROR
EXPECT_TRUE(-1 == at.read_bytes(buf, 5));
EXPECT_TRUE(NSAPI_ERROR_DEVICE_ERROR == at.get_last_error());
EXPECT_EQ(-1, at.read_bytes(buf, 5));
EXPECT_EQ(NSAPI_ERROR_DEVICE_ERROR, at.get_last_error());
}

TEST_F(TestATHandler, test_ATHandler_read_string)
Expand Down
2 changes: 1 addition & 1 deletion features/cellular/framework/AT/ATHandler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ class FileHandle;
extern const char *OK;
extern const char *CRLF;

#define BUFF_SIZE 16
#define BUFF_SIZE 32

/* AT Error types enumeration */
enum DeviceErrorType {
Expand Down