Skip to content

Internal delay loop code alignment to 16 #10932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2019
Merged

Internal delay loop code alignment to 16 #10932

merged 1 commit into from
Jul 3, 2019
+1 −1

Conversation

tymoteuszblochmobica
Copy link
Contributor

Description

Delay loop code alignment to 16 for decreasing execution time.
Its used by Wait_ns (...)

Pull request type

[x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@kjbracey-arm
@pan-

Release Notes

@tymoteuszblochmobica tymoteuszblochmobica mentioned this pull request Jul 1, 2019
Closed
@kjbracey
Copy link
Contributor

kjbracey commented Jul 1, 2019 •
edited
Loading

Could you also make it + 1 while you're touching this file, for that 1-instruction saving.

@tymoteuszblochmobica
Copy link
Contributor Author

delay_loop ((void(*)()) ((uintptr_t) delay_loop_code + 1)) is from your PR
#10609 and already merged to master

@ciarmcom ciarmcom requested review from kjbracey, pan- and a team July 1, 2019 15:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 1, 2019

@tymoteuszblochmobica, thank you for your changes.
@kjbracey-arm @pan- @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team July 1, 2019 15:00
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 2, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 2, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 34db82e into ARMmbed:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@kjbracey kjbracey kjbracey approved these changes

@pan- pan- Awaiting requested review from pan-

Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tymoteuszblochmobica @kjbracey @ciarmcom @0xc0170 @mbed-ci