Skip to content

Fix SAADC resolution for nRF52-based targets #10939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2019
Merged

Fix SAADC resolution for nRF52-based targets #10939

merged 2 commits into from
Jul 3, 2019

Conversation

AGlass0fMilk
Copy link
Member

@AGlass0fMilk AGlass0fMilk commented Jul 1, 2019 •
edited
Loading

Resolution set in sdk_config for both nRF52840 and nRF52832 was set to 10 bits. The HAL implementation of analogin_read_u16 assumes 12-bit range during scaling to Mbed's 16-bit resolution standard. This caused incorrect readings to be returned.

https://github.com/ARMmbed/mbed-os/blob/1cecfa480ff14483eeffb1a461c1d2578c3e9a4a/targets/TARGET_NORDIC/TARGET_NRF5x/TARGET_NRF52/analogin_api.c#L129-L131#

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@AGlass0fMilk
Fix SAADC resolution set in sdk_config. analogin_read_u16 assumes 12-…
b08a26b 
…bit range but config was set to 10 bit range causing incorrect readings to be returned.
@AGlass0fMilk
Apply same resolution fix to nRF52832 targets
f2b8836
@ciarmcom ciarmcom requested a review from a team July 1, 2019 17:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 1, 2019

@AGlass0fMilk, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 2, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 2, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@OPpuolitaival
Copy link
Contributor

Started CI because testing one CI change

@mbed-ci
Copy link

mbed-ci commented Jul 3, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 0e3a963 into ARMmbed:master Jul 3, 2019
@AGlass0fMilk AGlass0fMilk mentioned this pull request Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AGlass0fMilk @ciarmcom @0xc0170 @mbed-ci @OPpuolitaival @bulislaw