Skip to content

Update I2CTester for fpga-ci-test-shield #10944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 4, 2019
Merged

Update I2CTester for fpga-ci-test-shield #10944

merged 3 commits into from
Jul 4, 2019

Conversation

maciejbocianski
Copy link
Contributor

This PR updates I2CTester implementation to cover changes done in i2c pga-ci-test-shield implementation (see https://github.com/ARMmbed/fpga-ci-test-shield/pull/78)

I2CTester implementation updates:

  • upgrade checksum calculation
  • add address mismatch statistics

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@jamesbeyond @fkjagodzinski @mprse @c1728p9 @mrcoulter45

Release Notes

@ciarmcom
Copy link
Member

ciarmcom commented Jul 2, 2019

@maciejbocianski, thank you for your changes.
@mrcoulter45 @jamesbeyond @fkjagodzinski @mprse @c1728p9 @ARMmbed/mbed-os-maintainers please review.

@maciejbocianski
Copy link
Contributor Author

astyle fixed

mrcoulter45
mrcoulter45 approved these changes Jul 2, 2019
View reviewed changes
mprse
mprse approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@mprse mprse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I only suggest adding TESTER_I2C_NUMBER_DEV_ADDR_MISMATCHES_SIZE.

@maciejbocianski
Copy link
Contributor Author

ESTER_I2C_NUMBER_DEV_ADDR_MISMATCHES_SIZE added

fkjagodzinski
fkjagodzinski reviewed Jul 3, 2019
View reviewed changes
fkjagodzinski
fkjagodzinski reviewed Jul 3, 2019
View reviewed changes
fkjagodzinski
fkjagodzinski approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@fkjagodzinski fkjagodzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'd just update the docs to be easier to understand.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 3, 2019

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 3, 2019

CI had to be restarted

@OPpuolitaival
Copy link
Contributor

Cloud client issues seems not to be related this PR. Need to retry a bit later

@mbed-ci
Copy link

mbed-ci commented Jul 3, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test

@0xc0170 0xc0170 merged commit b55344c into ARMmbed:master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@mrcoulter45 mrcoulter45 mrcoulter45 approved these changes

@fkjagodzinski fkjagodzinski fkjagodzinski approved these changes

@mprse mprse mprse approved these changes

@c1728p9 c1728p9 Awaiting requested review from c1728p9

@jamesbeyond jamesbeyond Awaiting requested review from jamesbeyond

Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@maciejbocianski @ciarmcom @0xc0170 @OPpuolitaival @mbed-ci @c1728p9 @mrcoulter45 @fkjagodzinski @mprse @adbridge