Release candidate for mbed-os-5.13.1 #10952

artokin · 2019-07-03T13:21:32Z

No description provided.

Check that the RX or TX interrupt is enabled before calling a registered handler with RxIrq or TxIrq arg.

…e fix

Flagging these functions out will reduce flash size more than 3k.

… 2. Remove macro MBEDTLS_PSA_CRYPTO_C from PSA targets Signed-off-by: Devaraj Ranganna <[email protected]>

Signed-off-by: Devaraj Ranganna <[email protected]>

…size Adding a check to let application or target force increase idle thread stack size.

As the build tool in mbed-os 5.13 cannot appropriately deal with a segmented bootloader when combining it with an application, this commit adjusts the size reserved for interrupts (via the linker file) to avoid a bootloader segmentation due to an unpopulated ROM area. The microcontroller has a total of 60 vector interrupts + 16 exception handlers. The allocated ROM flash for interrupts should be (60 + 16) x word size in bytes = 76 x 4 = 304 = 0x130. This commit changes the interrupt reserved space from 0x140 to 0x130.

In particular and as kindly suggested by Przemec S. : 1. Add setup/teardown handler’s for all cases. This disables sys-tick, so there should be no unexpected lp ticker interrupt scheduling. 2. Modify setup/teardown handler’s: remove suspension of lp/us tickers, so they can count as this is required by test_lock_unlock_test_check test case. 3. Use TEST_ASSERT_TRUE(sleep_manager_can_deep_sleep_test_check()) after setting interrupt to cope with STM specific handling (CMPOK interrupt with deep-sleep locked). This performs wait only if needed and will not affect other targets which do not need extra wait. 4. Move sleep_manager_lock_deep_sleep() after TEST_ASSERT_TRUE(sleep_manager_can_deep_sleep_test_check()) 5. Use TEST_ASSERT_TRUE(sleep_manager_can_deep_sleep_test_check()) in test_lock_unlock_test_check to let lower layers manage deep sleep.

and avoid associated warning ...

Changes: - restore the original form of setup/teardown handlers, - test_lock_unlock_test_check(): do not use common ticker layer (Timer, Timeout). Use only ticker HAL layer. - Increase DEEP_SLEEP_TEST_CHECK_WAIT_DELTA_US delta.

…ayer to count elapsed time.

now that sleep_manager_can_deep_sleep_test_check() is based on wait_ns

With the DEEP_SLEEP_TEST_CHECK_WAIT_DELTA_US increased, we now have TEST_ASSERT_UINT64_WITHIN(delta=1000, expected=1000, actual=1000) so this assertion needed to be updated. What we need is the deep sleep to be enabled after the programed interrupt has fired and before a 2ms timeout expiration, which means >= 1000 and < 2000.

Add missing `lp_ticker_clear_interrupt()` in the interrput handler used in `test_lock_unlock_test_check()` test. Remove redefined `us_to_ticks()`.

Fix PWM glitch on write(), TARGET_STM/pwmout_api.c, #10734

Running PowerShell script on some windows machines is blocked. To avoid this problem script was replace by the code run directly in PowerShell console.

0xc0170 · 2019-07-03T21:40:08Z

CI started

mbed-ci · 2019-07-03T23:56:33Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

teetak01

This does not pass Client tests.

mbed compile -t ARM -m LPC55S69_NS --profile release --app-config wifi_esp8266_v4.json
[ERROR] Contents of region bootloader1 does not fit

This is increasing the binary size enough to break compilation with LPC55S69_NS target.

teetak01 · 2019-07-04T06:34:29Z

This is related to target.restrict_size issues on this board (https://jira.arm.com/browse/IOTSTOR-880), which was fixed in #10791 and #10792, but it still does not seem to work as expected.

If this target does not compile, this is a release blocker.

0xc0170 · 2019-07-04T07:21:25Z

@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-core You were involved in fixing previous fixes, please review these and lets find out why it's not working.

I'll set IOTSTOR-880 as a blocker now

teetak01 · 2019-07-04T07:46:47Z

I verified that reverting #10792 fixes the compilation.

Revert "Fix: Allow target size restriction for LPC55S69"

This reverts commit 4451d64ea80405d70a708f44fc43030e0d34ced4.

This reverts commit 4451d64. We postpone this fix to 5.13.2 due to its breakages for client for this target. It needs more work.

0xc0170 · 2019-07-04T08:01:46Z

@teetak01 👍

Revert pushed, comment to the PR added as well. Will notify core team about this

0xc0170 · 2019-07-04T08:07:39Z

CI restarted

teetak01

Verified that the tests are passing now.

mbed-ci · 2019-07-04T09:30:28Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

hugueskamba · 2019-07-05T07:10:33Z

This is related to target.restrict_size issues on this board (https://jira.arm.com/browse/IOTSTOR-880), which was fixed in #10791 and #10792, but it still does not seem to work as expected.

If this target does not compile, this is a release blocker.

@Teemu Did you increase the target.restrict_size in mbed_app.json to 0x5CE00?

hugueskamba · 2019-07-05T07:25:06Z

Here is what I just did to build.

git clone [email protected]:ARMmbed/mbed-client-testapp.git
mbed deploy --protocol ssh
cd mbed-os && git cherry-pick 06c3a5bf25d443b6620362f241fd5b052b95f && cd ..
cp configs-psa/wifi_esp8266_v4.json mbed_app.json
Modified mbed_app.json in the following way:
In the "LPC55S69_NS" attribute, change the value of "target.restrict_size" and "update-client.storage-size" to 0x5CE00
Build a bootloader that includes the changes here: b0804c4
Point "target.bootloader_img" in mbed_app.json with the bootloader just built
mbed compile -t ARM -m LPC55S69_NS --profile mbed-os/tools/profiles/release.json

The build completes successfully.

teetak01 · 2019-07-05T07:38:06Z

@hugueskamba you are using the wrong application. mbed-client-testapp is internal test-tool.

The compilation issue is with https://github.com/armmbed/mbed-cloud-client-example

hugueskamba · 2019-07-05T07:50:27Z

@hugueskamba you are using the wrong application. mbed-client-testapp is internal test-tool.

The compilation issue is with https://github.com/armmbed/mbed-cloud-client-example

@teetak01 Did you use a bootloader hex that was build with a version of mbed-os that included the following? b0804c4

hugueskamba · 2019-07-05T07:54:02Z

@teetak01 @0xc0170
As a reminder this is what needed to be done.

Mbed OS team:
Change sector size determined by CMSIS to be 512 for LPC55S69 - DONE
Modify interrupt size from 0x140 to 0x130 for LPC55S69 - DONE

Bootloader team:
Take Mbed OS release with above changes to build bootloader for LPC55S69_NS

Client team:
Replace bootloader hex pointed to by "target.bootloader_img" with newly built bootloader.
Increase "target.restrict_size" and "update-client.storage-size" to "0x5CE00" when building mbed-client-testapp

teetak01 · 2019-07-05T08:34:15Z

I was already suspecting that this also requires a new bootloader. Thus the reverted change was a breaking change for existing applications, and can only go to Mbed OS major release, not to a patch release. The major release also has to happen at the same time client release provides the updated bootloader and configuration.

Thus this fix needs to be delayed to Mbed OS 5.14.0.

0xc0170 · 2019-07-05T09:15:29Z

Moving the referenced fix to 5.14

0xc0170 · 2019-07-05T09:16:42Z

Thank you!

Filip Jagodzinski and others added 30 commits July 3, 2019 16:21

STM32WB: Fix serial IRQ handling

4b3cb5d

Check that the RX or TX interrupt is enabled before calling a registered handler with RxIrq or TxIrq arg.

K22F: Fix serial IRQ handling

de46fa4

Check that the RX or TX interrupt is enabled before calling a registered handler with RxIrq or TxIrq arg.

K24F: Fix serial IRQ handling

8030ced

Check that the RX or TX interrupt is enabled before calling a registered handler with RxIrq or TxIrq arg.

KW41Z: Fix serial IRQ handling

c56c15e

Check that the RX or TX interrupt is enabled before calling a registered handler with RxIrq or TxIrq arg.

KW24D: Fix serial IRQ handling

ffbb125

Check that the RX or TX interrupt is enabled before calling a registered handler with RxIrq or TxIrq arg.

KL82Z: Fix serial IRQ handling

c694e29

Check that the RX or TX interrupt is enabled before calling a registered handler with RxIrq or TxIrq arg.

KL43Z: Fix serial IRQ handling

7fd7b9e

Check that the RX or TX interrupt is enabled before calling a registered handler with RxIrq or TxIrq arg.

K66F: Fix serial IRQ handling

1524209

Check that the RX or TX interrupt is enabled before calling a registered handler with RxIrq or TxIrq arg.

KL27Z: Fix serial IRQ handling

45a3d29

Check that the RX or TX interrupt is enabled before calling a registered handler with RxIrq or TxIrq arg.

K82F: Fix serial IRQ handling

ebf7ecc

Check that the RX or TX interrupt is enabled before calling a registered handler with RxIrq or TxIrq arg.

microlib support: Specify compiler version unable to build without th…

ac2d434

…e fix

TLSSocket: print certificate info only when tracing is enabled

80469e2

Flagging these functions out will reduce flash size more than 3k.

Add STM32H743ZI to IAR export definition

a518a76

1. Include MBEDTLS_CONFIG_FILE before evaluating MBEDTLS_PSA_CRYPTO_C…

8e1d3dc

… 2. Remove macro MBEDTLS_PSA_CRYPTO_C from PSA targets Signed-off-by: Devaraj Ranganna <[email protected]>

Remove MBEDTLS_PSA_CRYPTO_C from PSA NS targets

b938402

Signed-off-by: Devaraj Ranganna <[email protected]>

Allow target or application level definition of extra TICKLESS stack …

91ab957

…size Adding a check to let application or target force increase idle thread stack size.

Fix compilation issue for targets without LPTICKER or USTICKER

342782b

Remove unused variable

d5648da

and avoid associated warning ...

Further modifications in Sleep Manager test.

a666e41

Changes: - restore the original form of setup/teardown handlers, - test_lock_unlock_test_check(): do not use common ticker layer (Timer, Timeout). Use only ticker HAL layer. - Increase DEEP_SLEEP_TEST_CHECK_WAIT_DELTA_US delta.

sleep_manager_can_deep_sleep_test_check(): do not use ticker common l…

8ab1611

…ayer to count elapsed time.

Increase DEEP_SLEEP_TEST_CHECK_WAIT_DELTA_US

f045050

now that sleep_manager_can_deep_sleep_test_check() is based on wait_ns

Tests: SleepManager: Fix test_check for NRF5X

52c8fa6

Add missing `lp_ticker_clear_interrupt()` in the interrput handler used in `test_lock_unlock_test_check()` test. Remove redefined `us_to_ticks()`.

STM32: pwmout_write: configure channel only when not already enabled

ece8777

Fix PWM glitch on write(), TARGET_STM/pwmout_api.c, #10734

usb_device-msd test: fix powershell unmount script issue

7b0c650

Running PowerShell script on some windows machines is blocked. To avoid this problem script was replace by the code run directly in PowerShell console.

usb_device-msd test: improve error handling

3d0771a

usb_device-msd test: disable host side unmount on windows machines

2ab6c95

usb_device-msd test: docs update

1c475be

0xc0170 added ready for merge and removed needs: review labels Jul 4, 2019

teetak01 suggested changes Jul 4, 2019

View reviewed changes

0xc0170 added needs: work and removed ready for merge labels Jul 4, 2019

Revert "Fix: Allow target size restriction for LPC55S69"

5b52d6d

This reverts commit 4451d64. We postpone this fix to 5.13.2 due to its breakages for client for this target. It needs more work.

0xc0170 added needs: CI and removed needs: work labels Jul 4, 2019

teetak01 approved these changes Jul 4, 2019

View reviewed changes

0xc0170 added ready for merge and removed needs: CI labels Jul 4, 2019

0xc0170 approved these changes Jul 4, 2019

View reviewed changes

0xc0170 merged commit 9cab583 into mbed-os-5.13 Jul 4, 2019

0xc0170 removed the ready for merge label Jul 4, 2019

Release candidate for mbed-os-5.13.1 #10952

Release candidate for mbed-os-5.13.1 #10952

Uh oh!

Conversation

artokin commented Jul 3, 2019

Uh oh!

0xc0170 commented Jul 3, 2019

Uh oh!

mbed-ci commented Jul 3, 2019

Test run: SUCCESS

Uh oh!

teetak01 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

teetak01 commented Jul 4, 2019

Uh oh!

0xc0170 commented Jul 4, 2019

Uh oh!

teetak01 commented Jul 4, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Jul 4, 2019

Uh oh!

0xc0170 commented Jul 4, 2019

Uh oh!

teetak01 left a comment

Choose a reason for hiding this comment

Uh oh!

mbed-ci commented Jul 4, 2019

Test run: SUCCESS

Uh oh!

hugueskamba commented Jul 5, 2019

Uh oh!

hugueskamba commented Jul 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

teetak01 commented Jul 5, 2019

Uh oh!

hugueskamba commented Jul 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hugueskamba commented Jul 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

teetak01 commented Jul 5, 2019

Uh oh!

0xc0170 commented Jul 5, 2019

Uh oh!

0xc0170 commented Jul 5, 2019

Uh oh!

Uh oh!

teetak01 left a comment •

edited

Loading

teetak01 commented Jul 4, 2019 •

edited

Loading

hugueskamba commented Jul 5, 2019 •

edited

Loading

hugueskamba commented Jul 5, 2019 •

edited

Loading

hugueskamba commented Jul 5, 2019 •

edited

Loading