Skip to content

PSA TESTS: Include mbedtls/config.h before evaluating MBEDTLS_PSA_CRYPTO_C #10963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2019

Conversation

urutva
Copy link
Contributor

@urutva urutva commented Jul 4, 2019

Description

Include mbedtls/config.h before evaluating MBEDTLS_PSA_CRYPTO_C
Signed-off-by: Devaraj Ranganna [email protected]

Fixes #10888 (comment)

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@Patater @jeromecoutant

Release Notes

@ciarmcom ciarmcom requested review from Patater and a team July 4, 2019 15:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 4, 2019

@Devran01, thank you for your changes.
@Patater @ARMmbed/mbed-os-crypto @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

Copy link

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these files but not other similar files?

$ git grep -F -l 'crypto.h' |xargs grep -L -F 'mbedtls/config.h'
psa/crypto_access_control/COMPONENT_PSA_SRV_IPC/test_partition_proxy.h
psa/crypto_access_control/COMPONENT_SPE/test_partition.c
psa/entropy_inject/main.cpp

And do it this way rather than include psa/crypto.h?

@urutva
Copy link
Contributor Author

urutva commented Jul 8, 2019

@gilles-peskine-arm These tests were skipped because of the change I did with #10888. Basically removing MBEDTLS_PSA_CRYPTO_C from PSA targets. These tests evaluate MBEDTLS_PSA_CRYPTO_C without including mbedtls/config.h.

I wasn't aware that psa/crypto.h includes mbedtls/config.h. Including psa/crypto.h is a cleaner solution. I've updated the tests.

@artokin
Copy link
Contributor

artokin commented Jul 9, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 9, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 9, 2019

Restarted CI test (looks like CI deamon fialure)

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 9, 2019

Restarted again after deamon error

cc @ARMmbed/mbed-os-test

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 9, 2019

Failed again with the same error, @ARMmbed/mbed-os-test notified

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 10, 2019

Still valid issue in CI, will restart once fixed

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 11, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jul 11, 2019

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 2
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants