-
Notifications
You must be signed in to change notification settings - Fork 3k
PSA TESTS: Include mbedtls/config.h before evaluating MBEDTLS_PSA_CRYPTO_C #10963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Devaraj Ranganna <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these files but not other similar files?
$ git grep -F -l 'crypto.h' |xargs grep -L -F 'mbedtls/config.h'
psa/crypto_access_control/COMPONENT_PSA_SRV_IPC/test_partition_proxy.h
psa/crypto_access_control/COMPONENT_SPE/test_partition.c
psa/entropy_inject/main.cpp
And do it this way rather than include psa/crypto.h
?
Signed-off-by: Devaraj Ranganna <[email protected]>
@gilles-peskine-arm These tests were skipped because of the change I did with #10888. Basically removing I wasn't aware that psa/crypto.h includes mbedtls/config.h. Including psa/crypto.h is a cleaner solution. I've updated the tests. |
CI started |
Test run: FAILEDSummary: 1 of 4 test jobs failed Failed test jobs:
|
Restarted CI test (looks like CI deamon fialure) |
Restarted again after deamon error cc @ARMmbed/mbed-os-test |
Failed again with the same error, @ARMmbed/mbed-os-test notified |
Still valid issue in CI, will restart once fixed |
CI restarted |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Description
Include mbedtls/config.h before evaluating MBEDTLS_PSA_CRYPTO_C
Signed-off-by: Devaraj Ranganna [email protected]
Fixes #10888 (comment)
Pull request type
Reviewers
@Patater @jeromecoutant
Release Notes