Skip to content

ESP8266: fix driver's support AT firmware version #10967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2019
Merged

ESP8266: fix driver's support AT firmware version #10967

merged 1 commit into from
Jul 8, 2019

Conversation

mtomczykmobica
Copy link

@mtomczykmobica mtomczykmobica commented Jul 5, 2019 •
edited
Loading

…version 1.6 or above support AT+CWCOUNTRY command. Command AT+CWLAP format is different for version 1.6 and above

Description

Made two changes:

  1. Command AT+CWCOUNTRY is used onlu for version 1.6 and above.
  2. Command AT+CWLAP has different format for version 1.6 and above. Parse response was implemented correct and support two different version but same command was only in one version. It was fixed in this pull request.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ciarmcom

Release Notes

ESP8266 driver fix to works with older firmware version of ESP8266 module.

Need to change ESP8266 driver's support AT firmware version. Only AT …
9ae4463 
…version 1.6 0r above support AT+CWCOUNTRY command. Command AT+CWLAP format is different for version 1.6 and above
@ciarmcom ciarmcom requested review from ciarmcom and a team July 5, 2019 09:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 5, 2019

@mtomczykmobica, thank you for your changes.
@ciarmcom @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 changed the title Need to change ESP8266 driver's support AT firmware version. Only AT … ESP8266: fix driver's support AT firmware version Jul 5, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 5, 2019

I edited the title, still might need an update to describe in one short sentence what is this fixing (used in the release notes)

@mtomczykmobica
Copy link
Author

Edited description and added short sentence what is this fixing.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 5, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 5, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@artokin artokin merged commit 492d10c into ARMmbed:master Jul 8, 2019
@evedon evedon mentioned this pull request Nov 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@ciarmcom ciarmcom Awaiting requested review from ciarmcom

Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mtomczykmobica @ciarmcom @0xc0170 @mbed-ci @AnttiKauppila @adbridge @artokin