Skip to content

Add IM880B as a new target platform #10970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

itziardelatorre
Copy link
Contributor

Description

Adds IM880B as a new platform.

The iM880B is a compact and low-cost radio module that operates in the unlicensed 868 MHz band and combines a powerful Cortex-M3 controller with the new LoRa® transceiver SX1272 of Semtech Corporation.
More details available at https://wireless-solutions.de/products/radiomodules/im880b-l.html

Please find attached the corresponding test results.
2019-05-24-TESTS_IM880B.zip

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

For the test, the downlink sequence counter of the downlink messages has been incremented by 1600 (< MAX_FCNT_GAP) several times. For example, until 64005 and following situation was shown:

Downlink sequence counter increased to 64005 (by 1600 steps)
The radio module accepts this, as expected.
After that, downlink sequence counter increased to 65536 (rollover for 32 bits sequence counter)
The radio module rejects this frame
With the change everything works fine.
For the test, the downlink sequence counter of the downlink messages has been incremented by 1600 (< MAX_FCNT_GAP) several times. For example, until 64005 and following situation was shown:

- Downlink sequence counter increased to 64005 (by 1600 steps)
The radio module accepts this, as expected.
- After that, downlink sequence counter increased to 65536 (rollover for 32 bits sequence counter)
The radio module rejects this frame

With the change everything works fine.
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 5, 2019

The same problem as previous PR, few files have wrong line endings (windows), like this one targets/TARGET_STM/TARGET_STM32L1/TARGET_IM880B/device/TOOLCHAIN_ARM_MICRO/startup_stm32l151xba.S. I am trying to fix it and rebase (no merge commits).

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 5, 2019

Commit c86ec8d should not be here, it's fix for Lorawan, should be sent separately. This will be dependency for this PR, we will mark it as such.

It is applied here 3x ? Can you please just add your target, without merging anything.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 5, 2019

I cherry-picked the last commit on top of latest master, here it's overview: https://github.com/ARMmbed/mbed-os/compare/master...0xc0170:test_target?expand=1 (this is what should be in this PR, I can create new PR if that helps, let me know).

@itziardelatorre
Copy link
Contributor Author

This would be really helpful. Thanks again for your support.

@ciarmcom ciarmcom requested review from a team July 5, 2019 09:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 5, 2019

@itziardelatorre, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-test please review.

@itziardelatorre
Copy link
Contributor Author

@0xc0170 Could you please confirm me if a new PR is required? Could you please create it with your update? Thanks again.

@0xc0170 0xc0170 removed request for a team July 5, 2019 09:31
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 5, 2019

I'll create new PR with onyl adding target. Lorawan fix - if still needed, please send it as new PR

@0xc0170 0xc0170 closed this Jul 5, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 5, 2019

Follow up #10972

@itziardelatorre
Copy link
Contributor Author

Lorawan fix already accepted in a separated PR. I do not know why it appears here again. Thanks.

@itziardelatorre itziardelatorre deleted the add_new_target_IM880B branch July 10, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants