Fix bug with CAN loopback implementation on LPC11c14 #1099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ACK' to 'CANTEST_LBACK' like it is implemented in the C_CAN controller for the LPC1549.
0xc0170
added a commit
that referenced
this pull request
May 12, 2015
Fix bug with CAN loopback implementation on LPC11c14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While compiling and running the updated MBed repository code for the LPC11c14, I discovered that the can_api.c file in the \LPC11XX_11CXX\LPC11CXX target folder was not building correctly. It appears that there is a spurious "CANCNTL_LBACK" which should actually be "CANTEST_LBACK." I have modified the file to mirror the contents of the can_api.c file in the LPC15XX target folder and it appears to work now.