Removing absolute paths to compiler executables #10997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VSCode exporter was generating a launch config that contained absolute paths to the compiler executables. It makes more sense to use the executables that are installed into the system PATH.
|
@mark-edgeworth, thank you for your changes. |
bulislaw
approved these changes
Jul 9, 2019
0xc0170
approved these changes
Jul 9, 2019
|
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
I don't know how to diagnose the test failure here. Help! |
|
It's CI internal issue, cc @ARMmbed/mbed-os-test |
|
Still valid CI issue, will restart once fixed |
|
CI restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VSCode exporter was generating a launch config that contained absolute paths to the
compiler executables. It makes more sense to use the executables that are
installed into the system PATH.
Pull request type
Reviewers
@madchutney
Release Notes
Uses tools that are installed on the user's system; user needs to have the tools on the system path.