Skip to content

FPGA SPI: remove 4 and 12 bits size support #11009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2019

Conversation

jeromecoutant
Copy link
Collaborator

Description

As it seems there is no device using this 4 and 12 size, proposition is to remove test ?

Thx

@LMESTM @c1728p9 @MarceloSalazar @ithinuel

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ithinuel
Copy link
Member

ithinuel commented Jul 9, 2019

Some targets such as the MK66F from NXP do support symbols from 4 to 16bits ( https://www.nxp.com/docs/en/reference-manual/K66P144M180SF5RMV2.pdf#d5667e5a1310_d11e7876 ).
The upcoming SPI api has a capability structure to declare what size are supported.

@ciarmcom ciarmcom requested review from a team July 9, 2019 23:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 9, 2019

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-hal @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@mprse mprse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have detailed requirements for the old SPI API which would strictly specify the defined behavior. Please consider this test as an example which shows some capabilities of the FPGA-Test-Shield.

On SPI feature branch (https://github.com/ARMmbed/mbed-os/tree/feature-hal-spec-spi) more expanded SPI test can be found.

I think that we can remove these cases, but please remove them permanently.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we can remove these cases, but please remove them permanently.

+1, we got git to revert back if needed, no need to keep "dead" code

@jeromecoutant
Copy link
Collaborator Author

Dead code removed.

Seems that the revert of this PR should come in the SPI feature branch!

@jeromecoutant
Copy link
Collaborator Author

Can you start CI ?

@jamesbeyond
Copy link
Contributor

CI Started

@mbed-ci
Copy link

mbed-ci commented Jul 18, 2019

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts

@SeppoTakalo SeppoTakalo dismissed 0xc0170’s stale review August 5, 2019 14:08

Test removed, dismissing the review.

@SeppoTakalo SeppoTakalo merged commit fb7bbd2 into ARMmbed:master Aug 5, 2019
@jeromecoutant jeromecoutant deleted the PR_SPI4 branch September 12, 2019 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants