-
Notifications
You must be signed in to change notification settings - Fork 3k
FPGA SPI: remove 4 and 12 bits size support #11009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some targets such as the MK66F from NXP do support symbols from 4 to 16bits ( https://www.nxp.com/docs/en/reference-manual/K66P144M180SF5RMV2.pdf#d5667e5a1310_d11e7876 ). |
@jeromecoutant, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not have detailed requirements for the old SPI API which would strictly specify the defined behavior. Please consider this test as an example which shows some capabilities of the FPGA-Test-Shield.
On SPI feature branch (https://github.com/ARMmbed/mbed-os/tree/feature-hal-spec-spi) more expanded SPI test can be found.
I think that we can remove these cases, but please remove them permanently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we can remove these cases, but please remove them permanently.
+1, we got git to revert back if needed, no need to keep "dead" code
Dead code removed. Seems that the revert of this PR should come in the SPI feature branch! |
Can you start CI ? |
CI Started |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Test removed, dismissing the review.
Description
As it seems there is no device using this 4 and 12 size, proposition is to remove test ?
Thx
@LMESTM @c1728p9 @MarceloSalazar @ithinuel
Pull request type