Nuvoton: Enlarge required deep sleep latency #11020
Conversation
There was a problem hiding this comment.
One question - why 1 fixes it ? why not 2 for instance - might be good to explain this in the commit itself. It's not just to pass the test - why it fails (what is this fixing, is there some reconfig in place that takes time and introducing this latency?). I might be asking too much but this might be helpful to know for a reader.
…iling This test requires total latency (tot = h/w + s/w) (wakeup from deepsleep) be under 1ms. To check the issue, measure total latency on Nuvoton targets: TARGET EXP(us) EXP+TOL(us) ACT(us) NANO130 42000 43000 42939 NUC472 42000 43000 42236 M453 42000 43000 43274 M487 42000 43000 42877 M2351 42000 43000 43213 Checking h/w spec, h/w latency (wakeup time from normal power-down mode) on M487/M2351 is just 1us (n/a on other targets). S/W latency plays the major part here. S/W latency relies on system performance. On Nuvoton targets, 'LPTICKER_DELAY_TICKS' possibly complicates the test. Anyway, to pass the test, add extra 1ms latency (deep-sleep-latency) in targets.json for Nuvoton targets.
ccli8
force-pushed
the
nuvoton_wakeup_latency
branch
from
769a530 to
1e5a52a
Compare
|
Add the commit message. According to h/w spec, h/w latency is 1us on Nuvoton targets. The total latency majorly comes from s/w latency. Dependent on system performance (cpu+cache+...), s/w latency ranges from 250us to 1250us on Nuvoton targets. Default tolerance is 1ms. Add extra 1ms tolerance for this test. On non-Nuvoton target K64F, its total latency is 400us. Without its h/w spec, assuming its h/w latency is also small, s/w latency still plays the major part. |
|
Any update? |
|
CI started |
Test run: FAILEDSummary: 3 of 11 test jobs failed Failed test jobs:
|
|
Restarted entire CI pipeline (failures not related to this changeset). |
Test run: FAILEDSummary: 3 of 11 test jobs failed Failed test jobs:
|
|
Restarted tests, exporters have an issue on master, will be fixed |
|
CI restarted |
Test run: FAILEDSummary: 1 of 12 test jobs failed Failed test jobs:
|
Not valid CI config, new jobs will have this fixed. All good |
Description
This PR is to pass wake-up from deep-sleep test such as
mbedmicro-rtos-mbed-systimerfor Nuvoton targets when in tickless from lp-ticker mode.Pull request type